From 5de5d8a5c0aa864bbf79a299cf5b9d5a1547941a Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Wed, 26 Mar 2014 09:02:42 +0100 Subject: ptx: avoid --format long option falling through into --help * src/ptx.c (main): Add a 'break' after the --format handling case. Otherwise it would fall through into the usage case. * tests/misc/ptx.pl: Add test cases for --format=tex and --format=roff. * NEWS (Bug fixes): Mention the fix. Bug introduced in 1999-04-04 commit, SH-UTILS-1_16f-269-gd815c15. Spotted by coverity (MISSING_BREAK). --- tests/misc/ptx.pl | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'tests') diff --git a/tests/misc/ptx.pl b/tests/misc/ptx.pl index 2db953a92..8a91d616a 100755 --- a/tests/misc/ptx.pl +++ b/tests/misc/ptx.pl @@ -33,6 +33,13 @@ my @Tests = # with coreutils-6.12 and earlier, this would act like "ptx F1 F1" ["2files", '-g1 -w1', {IN=>{F1=>"a"}}, {IN=>{F2=>"b"}}, {OUT=>" a\n b\n"}], + +# with coreutils-8.22 and earlier, the --format long option would +# fall through into the --help case. +["format-r", '--format=roff', {IN=>"foo\n"}, + {OUT=>".xx \"\" \"\" \"foo\" \"\"\n"}], +["format-t", '--format=tex', {IN=>"foo\n"}, + {OUT=>"\\xx {}{}{foo}{}{}\n"}], ); @Tests = triple_test \@Tests; -- cgit v1.2.3-70-g09d2