From 3b997a9bcb05198c880e5d1605a3c96c1d7f9c5d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 15 Nov 2009 09:25:29 +0100 Subject: tail -F can fail to track a file after it's been rotated Tailing forever and by-name (--follow=name, -F), tail would sometimes fail to follow a file that had been removed via rename. If you can't apply this patch and have tail 7.6 or newer, you can work around the bug via the undocumented --disable-inotify option. * src/tail.c (tail_forever_inotify): When tailing by name (-F), do not un-watch a file upon receipt of the IN_MOVE_SELF event. Reported by Arjan Opmeer in http://bugs.debian.org/548439. * NEWS (Bug fixes): Mention it. Also see http://marc.info/?l=coreutils-bug&m=125829031916515 * tests/Makefile.am (TESTS): Add tail-2/inotify-rotate. * tests/tail-2/inotify-rotate: New test. --- tests/tail-2/inotify-rotate | 55 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100755 tests/tail-2/inotify-rotate (limited to 'tests/tail-2') diff --git a/tests/tail-2/inotify-rotate b/tests/tail-2/inotify-rotate new file mode 100755 index 000000000..f45486aa9 --- /dev/null +++ b/tests/tail-2/inotify-rotate @@ -0,0 +1,55 @@ +#!/bin/sh +# ensure that tail -F handles rotation + +# Copyright (C) 2009 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +if test "$VERBOSE" = yes; then + set -x + tail --version +fi + +. $srcdir/test-lib.sh +expensive_ + +# For details, see +# http://lists.gnu.org/archive/html/bug-coreutils/2009-11/msg00213.html + +# Perform at least this many iterations, because on multi-core systems +# the offending sequence of events can be surprisingly uncommon. +for i in $(seq 50); do + echo $i + rm -rf k x out + :>k && :>x && timeout 10 tail -F k > out 2>&1 & + pid=$! + sleep .1 + echo b > k; + # wait for b to appear in out + while :; do grep b out > /dev/null && break; done + mv x k + # wait for tail to detect the rename + while :; do grep tail: out > /dev/null && break; done + echo ok >> k + found=0 + # wait up to 10 seconds for "ok" to appear in out + for j in $(seq 100); do + grep ok out > /dev/null && { found=1; break; } + sleep 0.1 + done + kill $pid + test $found = 0 && { fail=1; cat out; break; } +done + +Exit $fail -- cgit v1.2.3-70-g09d2