From f7867e73caac82349e5623d04e46aaf784778644 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Wed, 27 Mar 2013 11:06:00 +0000 Subject: shuf: exit without reading if would never output * src/shuf.c (main): If -n0 specified then no data would ever be output, so exit without reading input. * tests/misc/shuf.sh: Augment the related test with this case. --- tests/misc/shuf.sh | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'tests/misc/shuf.sh') diff --git a/tests/misc/shuf.sh b/tests/misc/shuf.sh index 9c9526d4d..171b25a1f 100755 --- a/tests/misc/shuf.sh +++ b/tests/misc/shuf.sh @@ -57,4 +57,10 @@ cmp out exp || { fail=1; echo "missing NUL terminator?" 1>&2; } timeout 10 shuf -i1-$SIZE_MAX -n2 >/dev/null || { fail=1; echo "couldn't get a small subset" >&2; } +# Ensure shuf -n0 doesn't read any input or open specified files +touch unreadable || framework_failure_ +chmod 0 unreadable || framework_failure_ +shuf -n0 unreadable || fail=1 +shuf -n1 unreadable && fail=1 + Exit $fail -- cgit v1.2.3-54-g00ecf