From 6796698c9945d87236ffcc939137d0919ef04931 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Tue, 27 Oct 2015 13:13:59 +0000 Subject: all: quote string arguments in error messages These strings are often file names or other user specified parameters, which can give confusing errors in the presence of unexpected characters for example. * cfg.mk (sc_error_quotes): A new syntax check rule. * src/*.c: Wrap error() string arguments with quote(). * tests/: Adjust accordingly. * NEWS: Mention the improvement. --- tests/misc/shred-passes.sh | 64 +++++++++++++++++++++++----------------------- 1 file changed, 32 insertions(+), 32 deletions(-) (limited to 'tests/misc/shred-passes.sh') diff --git a/tests/misc/shred-passes.sh b/tests/misc/shred-passes.sh index 64216fd8a..c19cc7655 100755 --- a/tests/misc/shred-passes.sh +++ b/tests/misc/shred-passes.sh @@ -24,12 +24,12 @@ print_ver_ shred # 3 random passes and a single rename. printf 1 > f || framework_failure_ echo "\ -shred: f: pass 1/3 (random)... -shred: f: pass 2/3 (random)... -shred: f: pass 3/3 (random)... -shred: f: removing -shred: f: renamed to 0 -shred: f: removed" > exp || framework_failure_ +shred: 'f': pass 1/3 (random)... +shred: 'f': pass 2/3 (random)... +shred: 'f': pass 3/3 (random)... +shred: 'f': removing +shred: 'f': renamed to '0' +shred: 'f': removed" > exp || framework_failure_ shred -v -u f 2>out || fail=1 compare exp out || fail=1 @@ -39,9 +39,9 @@ compare exp out || fail=1 # to bypass the data passes touch f || framework_failure_ echo "\ -shred: f: removing -shred: f: renamed to 0 -shred: f: removed" > exp || framework_failure_ +shred: 'f': removing +shred: 'f': renamed to '0' +shred: 'f': removed" > exp || framework_failure_ shred -v -u f 2>out || fail=1 compare exp out || fail=1 @@ -52,29 +52,29 @@ compare exp out || fail=1 dd bs=100K count=1 if=/dev/zero | tr '\0' 'U' > Us || framework_failure_ printf 1 > f || framework_failure_ echo "\ -shred: f: pass 1/20 (random)... -shred: f: pass 2/20 (ffffff)... -shred: f: pass 3/20 (924924)... -shred: f: pass 4/20 (888888)... -shred: f: pass 5/20 (db6db6)... -shred: f: pass 6/20 (777777)... -shred: f: pass 7/20 (492492)... -shred: f: pass 8/20 (bbbbbb)... -shred: f: pass 9/20 (555555)... -shred: f: pass 10/20 (aaaaaa)... -shred: f: pass 11/20 (random)... -shred: f: pass 12/20 (6db6db)... -shred: f: pass 13/20 (249249)... -shred: f: pass 14/20 (999999)... -shred: f: pass 15/20 (111111)... -shred: f: pass 16/20 (000000)... -shred: f: pass 17/20 (b6db6d)... -shred: f: pass 18/20 (eeeeee)... -shred: f: pass 19/20 (333333)... -shred: f: pass 20/20 (random)... -shred: f: removing -shred: f: renamed to 0 -shred: f: removed" > exp || framework_failure_ +shred: 'f': pass 1/20 (random)... +shred: 'f': pass 2/20 (ffffff)... +shred: 'f': pass 3/20 (924924)... +shred: 'f': pass 4/20 (888888)... +shred: 'f': pass 5/20 (db6db6)... +shred: 'f': pass 6/20 (777777)... +shred: 'f': pass 7/20 (492492)... +shred: 'f': pass 8/20 (bbbbbb)... +shred: 'f': pass 9/20 (555555)... +shred: 'f': pass 10/20 (aaaaaa)... +shred: 'f': pass 11/20 (random)... +shred: 'f': pass 12/20 (6db6db)... +shred: 'f': pass 13/20 (249249)... +shred: 'f': pass 14/20 (999999)... +shred: 'f': pass 15/20 (111111)... +shred: 'f': pass 16/20 (000000)... +shred: 'f': pass 17/20 (b6db6d)... +shred: 'f': pass 18/20 (eeeeee)... +shred: 'f': pass 19/20 (333333)... +shred: 'f': pass 20/20 (random)... +shred: 'f': removing +shred: 'f': renamed to '0' +shred: 'f': removed" > exp || framework_failure_ shred -v -u -n20 --random-source=Us f 2>out || fail=1 compare exp out || fail=1 -- cgit v1.2.3-54-g00ecf