From d7619b5fe899074ef196154b2eec54d51290d450 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 8 Sep 2006 17:08:53 +0000 Subject: mv and "cp -r" no longer fail when invoked with two arguments where the first one names a directory and the second name ends in a slash and doesn't exist. E.g., "mv dir B/", for nonexistent B, now succeeds, once more. This reverts part of the 2004-06-27 change for 5.3.0. * NEWS: Say the above. * src/mv.c (target_directory_operand): Don't require (here) that the target operand "look like" a directory. This change pushes the test down to the rename syscall level, where a "mv dir existing-non-dir/" will mistakenly succeed on older systems that ignore trailing slashes in the rename destination argument. * src/cp.c (target_directory_operand): Likewise, but for cp. * tests/mv/trailing-slash: Exercise the above fixes. * tests/cp/trailing-slash: New file. * tests/cp/Makefile.am (EXTRA_DIST): Add trailing-slash. --- tests/cp/Makefile.am | 2 +- tests/cp/trailing-slash | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 tests/cp/trailing-slash (limited to 'tests/cp') diff --git a/tests/cp/Makefile.am b/tests/cp/Makefile.am index a96eab7ae..0b42f3a8a 100644 --- a/tests/cp/Makefile.am +++ b/tests/cp/Makefile.am @@ -31,7 +31,7 @@ TESTS = \ same-file cp-mv-backup symlink-slash slink-2-slink fail-perm dir-slash \ perm cp-HL special-bits link dir-rm-dest cp-parents deref-slink \ dir-vs-file into-self -EXTRA_DIST = $(TESTS) +EXTRA_DIST = $(TESTS) trailing-slash TESTS_ENVIRONMENT = \ MAKE=$(MAKE) \ CONFIG_HEADER=$(CONFIG_HEADER) \ diff --git a/tests/cp/trailing-slash b/tests/cp/trailing-slash new file mode 100644 index 000000000..0cdbfa7b5 --- /dev/null +++ b/tests/cp/trailing-slash @@ -0,0 +1,2 @@ +# this is just a place-holder. +# For trailing-slash-related tests, see ../mv/trailing-slash. -- cgit v1.2.3-54-g00ecf