From f3a0e9ebb26d92368238f6700fa973198c563968 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Thu, 25 Jun 2015 16:39:36 +0100 Subject: maint: clarify integer operations in recent commit * src/factor.c (print_uintmaxes): Comment that the value of n_out doesn't matter on error, and add an explicit cast to avoid any future warnings. Suggested by Jim Meyering RE commit v8.23-229-g4d2d6c5 --- src/factor.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/factor.c b/src/factor.c index 5b7ae22ab..60cf898aa 100644 --- a/src/factor.c +++ b/src/factor.c @@ -2331,7 +2331,10 @@ print_uintmaxes (uintmax_t t1, uintmax_t t0) uintmax_t q, r; if (t1 == 0) - n_out += printf ("%"PRIuMAX, t0); + { + /* n_out's value is inconsequential on error. */ + n_out += (size_t) printf ("%"PRIuMAX, t0); + } else { /* Use very plain code here since it seems hard to write fast code @@ -2340,7 +2343,7 @@ print_uintmaxes (uintmax_t t1, uintmax_t t0) r = t1 % 1000000000; udiv_qrnnd (t0, r, r, t0, 1000000000); print_uintmaxes (q, t0); - n_out += printf ("%09u", (unsigned int) r); + n_out += (size_t) printf ("%09u", (unsigned int) r); } } -- cgit v1.2.3-70-g09d2