From e1788d9ed9c22811ab73163270cfc11ed36c8abd Mon Sep 17 00:00:00 2001
From: Pádraig Brady <P@draigBrady.com>
Date: Fri, 25 Feb 2011 12:27:25 +0000
Subject: dd: warn when we disable oflag=direct not at EOF

An alternative to this is to auto enable iflag=fullblock
when oflag=direct and bs= is specified.
It was thought better though, to warn about the specific issue,
and give full control of dd's options to the user.

* src/dd.c (iwrite): Warn, when we write after having
disabled O_DIRECT.
See https://bugzilla.redhat.com/show_bug.cgi?id=614605
---
 src/dd.c | 6 ++++++
 1 file changed, 6 insertions(+)

(limited to 'src')

diff --git a/src/dd.c b/src/dd.c
index daddc1ed6..fd468a647 100644
--- a/src/dd.c
+++ b/src/dd.c
@@ -837,6 +837,12 @@ iwrite (int fd, char const *buf, size_t size)
 {
   size_t total_written = 0;
 
+  if ((output_flags & O_DIRECT) && w_partial == 1)
+    {
+      error (0, 0, _("dd: warning: partial read; oflag=direct disabled; "
+                     "suggest iflag=fullblock"));
+    }
+
   if ((output_flags & O_DIRECT) && size < output_blocksize)
     {
       int old_flags = fcntl (STDOUT_FILENO, F_GETFL);
-- 
cgit v1.2.3-70-g09d2