From 242689c7f93de72693979f877dd31b3ef7178eea Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 28 Sep 2009 18:29:02 +0200 Subject: ls: with -LR, exit with status 2 upon detecting a cycle * src/ls.c (print_dir): Diagnosing the cycle is not enough. Also set exit status to 2. This is what Solaris' /bin/ls does, too. * tests/ls/infloop: Rework test: match both expected stdout and stderr. Require an exit status of 2 in this case. * doc/coreutils.texi (ls invocation): Mention that a loop provokes in an exit status of 2. * NEWS (Bug fixes): Mention it. Reported by Yang Ren in http://bugzilla.redhat.com/525402. * THANKS: Correct ordering of Yang Ren's names. --- src/ls.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/ls.c b/src/ls.c index 1bb6873ed..86f5c3260 100644 --- a/src/ls.c +++ b/src/ls.c @@ -2471,6 +2471,7 @@ print_dir (char const *name, char const *realname, bool command_line_arg) error (0, 0, _("%s: not listing already-listed directory"), quotearg_colon (name)); closedir (dirp); + set_exit_status (true); return; } -- cgit v1.2.3-54-g00ecf