From 492dcb2eb191b844a2fd5e51db3eed85289bea1f Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Sat, 15 Oct 2016 23:10:35 +0100 Subject: all: use die() rather than error(EXIT_FAILURE) die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...); --- src/users.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/users.c') diff --git a/src/users.c b/src/users.c index d5c86f35c..ed174f017 100644 --- a/src/users.c +++ b/src/users.c @@ -23,6 +23,7 @@ #include #include "system.h" +#include "die.h" #include "error.h" #include "long-options.h" #include "quote.h" @@ -88,7 +89,7 @@ users (const char *filename, int options) STRUCT_UTMP *utmp_buf; if (read_utmp (filename, &n_users, &utmp_buf, options) != 0) - error (EXIT_FAILURE, errno, "%s", quotef (filename)); + die (EXIT_FAILURE, errno, "%s", quotef (filename)); list_entries_users (n_users, utmp_buf); -- cgit v1.2.3-54-g00ecf