From 492dcb2eb191b844a2fd5e51db3eed85289bea1f Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Sat, 15 Oct 2016 23:10:35 +0100 Subject: all: use die() rather than error(EXIT_FAILURE) die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...); --- src/unlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/unlink.c') diff --git a/src/unlink.c b/src/unlink.c index 51a26b190..3fbe95592 100644 --- a/src/unlink.c +++ b/src/unlink.c @@ -26,6 +26,7 @@ #include #include "system.h" +#include "die.h" #include "error.h" #include "long-options.h" #include "quote.h" @@ -83,7 +84,7 @@ main (int argc, char **argv) } if (unlink (argv[optind]) != 0) - error (EXIT_FAILURE, errno, _("cannot unlink %s"), quoteaf (argv[optind])); + die (EXIT_FAILURE, errno, _("cannot unlink %s"), quoteaf (argv[optind])); return EXIT_SUCCESS; } -- cgit v1.2.3-54-g00ecf