From 492dcb2eb191b844a2fd5e51db3eed85289bea1f Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Sat, 15 Oct 2016 23:10:35 +0100 Subject: all: use die() rather than error(EXIT_FAILURE) die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...); --- src/tac-pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/tac-pipe.c') diff --git a/src/tac-pipe.c b/src/tac-pipe.c index 976570a22..36c321f24 100644 --- a/src/tac-pipe.c +++ b/src/tac-pipe.c @@ -18,6 +18,8 @@ /* FIXME */ #include +#include "die.h" + /* FIXME: this is small for testing */ #define BUFFER_SIZE (8) @@ -71,7 +73,7 @@ buf_init_from_stdin (Buf *x, char eol_byte) } bytes_read = full_read (STDIN_FILENO, buf, BUFFER_SIZE); if (bytes_read != buffer_size && errno != 0) - error (EXIT_FAILURE, errno, _("read error")); + die (EXIT_FAILURE, errno, _("read error")); { struct B_pair bp; -- cgit v1.2.3-54-g00ecf