From 6796698c9945d87236ffcc939137d0919ef04931 Mon Sep 17 00:00:00 2001
From: Pádraig Brady <P@draigBrady.com>
Date: Tue, 27 Oct 2015 13:13:59 +0000
Subject: all: quote string arguments in error messages

These strings are often file names or other user specified
parameters, which can give confusing errors in
the presence of unexpected characters for example.

* cfg.mk (sc_error_quotes): A new syntax check rule.
* src/*.c: Wrap error() string arguments with quote().
* tests/: Adjust accordingly.
* NEWS: Mention the improvement.
---
 src/shuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/shuf.c')

diff --git a/src/shuf.c b/src/shuf.c
index ff2337d34..040b00028 100644
--- a/src/shuf.c
+++ b/src/shuf.c
@@ -520,7 +520,7 @@ main (int argc, char **argv)
       if (n_operands == 1)
         if (! (STREQ (operand[0], "-") || ! head_lines
                || freopen (operand[0], "r", stdin)))
-          error (EXIT_FAILURE, errno, "%s", operand[0]);
+          error (EXIT_FAILURE, errno, "%s", quote (operand[0]));
 
       fadvise (stdin, FADVISE_SEQUENTIAL);
 
-- 
cgit v1.2.3-54-g00ecf