From 6796698c9945d87236ffcc939137d0919ef04931 Mon Sep 17 00:00:00 2001
From: Pádraig Brady <P@draigBrady.com>
Date: Tue, 27 Oct 2015 13:13:59 +0000
Subject: all: quote string arguments in error messages

These strings are often file names or other user specified
parameters, which can give confusing errors in
the presence of unexpected characters for example.

* cfg.mk (sc_error_quotes): A new syntax check rule.
* src/*.c: Wrap error() string arguments with quote().
* tests/: Adjust accordingly.
* NEWS: Mention the improvement.
---
 src/readlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/readlink.c')

diff --git a/src/readlink.c b/src/readlink.c
index 1778f639a..2b61fda92 100644
--- a/src/readlink.c
+++ b/src/readlink.c
@@ -25,6 +25,7 @@
 #include "canonicalize.h"
 #include "error.h"
 #include "areadlink.h"
+#include "quote.h"
 
 /* The official name of this program (e.g., no 'g' prefix).  */
 #define PROGRAM_NAME "readlink"
@@ -170,7 +171,7 @@ main (int argc, char **argv)
         {
           status = EXIT_FAILURE;
           if (verbose)
-            error (0, errno, "%s", fname);
+            error (0, errno, "%s", quote (fname));
         }
     }
 
-- 
cgit v1.2.3-54-g00ecf