From 6796698c9945d87236ffcc939137d0919ef04931 Mon Sep 17 00:00:00 2001
From: Pádraig Brady <P@draigBrady.com>
Date: Tue, 27 Oct 2015 13:13:59 +0000
Subject: all: quote string arguments in error messages

These strings are often file names or other user specified
parameters, which can give confusing errors in
the presence of unexpected characters for example.

* cfg.mk (sc_error_quotes): A new syntax check rule.
* src/*.c: Wrap error() string arguments with quote().
* tests/: Adjust accordingly.
* NEWS: Mention the improvement.
---
 src/pinky.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/pinky.c')

diff --git a/src/pinky.c b/src/pinky.c
index 71650bfae..f969e5b97 100644
--- a/src/pinky.c
+++ b/src/pinky.c
@@ -27,6 +27,7 @@
 #include "canon-host.h"
 #include "error.h"
 #include "hard-locale.h"
+#include "quote.h"
 #include "readutmp.h"
 
 /* The official name of this program (e.g., no 'g' prefix).  */
@@ -468,7 +469,7 @@ short_pinky (const char *filename,
   STRUCT_UTMP *utmp_buf = NULL;
 
   if (read_utmp (filename, &n_users, &utmp_buf, 0) != 0)
-    error (EXIT_FAILURE, errno, "%s", filename);
+    error (EXIT_FAILURE, errno, "%s", quote (filename));
 
   scan_entries (n_users, utmp_buf, argc_names, argv_names);
 
-- 
cgit v1.2.3-54-g00ecf