From 6796698c9945d87236ffcc939137d0919ef04931 Mon Sep 17 00:00:00 2001
From: Pádraig Brady <P@draigBrady.com>
Date: Tue, 27 Oct 2015 13:13:59 +0000
Subject: all: quote string arguments in error messages

These strings are often file names or other user specified
parameters, which can give confusing errors in
the presence of unexpected characters for example.

* cfg.mk (sc_error_quotes): A new syntax check rule.
* src/*.c: Wrap error() string arguments with quote().
* tests/: Adjust accordingly.
* NEWS: Mention the improvement.
---
 src/pathchk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/pathchk.c')

diff --git a/src/pathchk.c b/src/pathchk.c
index e05ecf7f4..d9f3bceb6 100644
--- a/src/pathchk.c
+++ b/src/pathchk.c
@@ -290,7 +290,7 @@ validate_file_name (char *file, bool check_basic_portability,
         file_exists = true;
       else if (errno != ENOENT || filelen == 0)
         {
-          error (0, errno, "%s", file);
+          error (0, errno, "%s", quote (file));
           return false;
         }
     }
@@ -393,7 +393,7 @@ validate_file_name (char *file, bool check_basic_portability,
 
                   default:
                     *start = '\0';
-                    error (0, errno, "%s", dir);
+                    error (0, errno, "%s", quote (dir));
                     *start = c;
                     return false;
                   }
-- 
cgit v1.2.3-54-g00ecf