From 492dcb2eb191b844a2fd5e51db3eed85289bea1f Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Sat, 15 Oct 2016 23:10:35 +0100 Subject: all: use die() rather than error(EXIT_FAILURE) die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...); --- src/mkfifo.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'src/mkfifo.c') diff --git a/src/mkfifo.c b/src/mkfifo.c index 51361732a..fef72f22f 100644 --- a/src/mkfifo.c +++ b/src/mkfifo.c @@ -23,6 +23,7 @@ #include #include "system.h" +#include "die.h" #include "error.h" #include "modechange.h" #include "quote.h" @@ -139,9 +140,9 @@ main (int argc, char **argv) ret = setfscreatecon (se_const (scontext)); if (ret < 0) - error (EXIT_FAILURE, errno, - _("failed to set default file creation context to %s"), - quote (scontext)); + die (EXIT_FAILURE, errno, + _("failed to set default file creation context to %s"), + quote (scontext)); } newmode = MODE_RW_UGO; @@ -150,14 +151,14 @@ main (int argc, char **argv) mode_t umask_value; struct mode_change *change = mode_compile (specified_mode); if (!change) - error (EXIT_FAILURE, 0, _("invalid mode")); + die (EXIT_FAILURE, 0, _("invalid mode")); umask_value = umask (0); umask (umask_value); newmode = mode_adjust (newmode, false, umask_value, change, NULL); free (change); if (newmode & ~S_IRWXUGO) - error (EXIT_FAILURE, 0, - _("mode must specify only file permission bits")); + die (EXIT_FAILURE, 0, + _("mode must specify only file permission bits")); } for (; optind < argc; ++optind) -- cgit v1.2.3-70-g09d2