From 03583f8d646f4cc4d5f91b7ed763c147a00e2f44 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 31 Mar 2011 17:59:16 +0200 Subject: maint: prohibit direct use of strncmp: prefer STREQ_LEN, STRNCMP_LIT * cfg.mk (sc_prohibit_strncmp): New rule, mostly from libvirt. * src/system.h (STREQ_LEN, STRPREFIX, STRNCMP_LIT): Define. * src/df.c (get_dev, get_point): Convert. * src/extent-scan.c (extent_need_sync): Likewise. * src/ls.c (is_colored, decode_switches): Likewise. (parse_ls_color, (print_color_indicator): Likewise. * src/md5sum.c (split_3): Likewise. * src/split.c (main, emit_ancillary_info): Likewise. * src/tr.c (look_up_char_class): Likewise. * src/uname.c (main): Likewise. * src/who.c (scan_entries): Likewise. --- src/md5sum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/md5sum.c') diff --git a/src/md5sum.c b/src/md5sum.c index 697689b3b..6f6e6373d 100644 --- a/src/md5sum.c +++ b/src/md5sum.c @@ -262,7 +262,7 @@ split_3 (char *s, size_t s_len, /* Check for BSD-style checksum line. */ algo_name_len = strlen (DIGEST_TYPE_STRING); - if (strncmp (s + i, DIGEST_TYPE_STRING, algo_name_len) == 0) + if (STREQ_LEN (s + i, DIGEST_TYPE_STRING, algo_name_len)) { if (s[i + algo_name_len] == ' ') ++i; -- cgit v1.2.3-54-g00ecf