From a037e838e15c9a698f1634398e0fe2726398d575 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Wed, 23 Sep 2009 10:10:51 +0100 Subject: maint: Use logical rather than bitwise operators on bools This is because bitwise operators are: - confusing and inconsistent in a boolean context - non short circuiting - brittle in C89 where bool can be an int (so > 1) --- src/install.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/install.c') diff --git a/src/install.c b/src/install.c index 03cb9ed7a..ca0309654 100644 --- a/src/install.c +++ b/src/install.c @@ -563,7 +563,7 @@ main (int argc, char **argv) } /* Check for invalid combinations of arguments. */ - if (dir_arg & strip_files) + if (dir_arg && strip_files) error (EXIT_FAILURE, 0, _("the strip option may not be used when installing a directory")); if (dir_arg && target_directory) -- cgit v1.2.3-54-g00ecf