From be9f38bf6c7c228bc0d749703060228b16793167 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Fri, 2 May 2014 01:23:21 +0100 Subject: numfmt: improve processing throughput by 800% The devmsg() calls that took quote_n() arguments, didn't normally output anything, but still incurred the overhead of those quote_n() calls. * src/numfmt.c (devmsg): Move the inline function with _internal_ enablement check to... * src/system.h: ...here as a variadic macro, with the enablement check at the outer level. * src/factor.c: As per numfmt.c but there is no performance change in this case. * NEWS: Mention the significant performance improvement. --- src/factor.c | 16 ---------------- 1 file changed, 16 deletions(-) (limited to 'src/factor.c') diff --git a/src/factor.c b/src/factor.c index c55edb894..63924d545 100644 --- a/src/factor.c +++ b/src/factor.c @@ -689,22 +689,6 @@ verify (W <= WIDE_UINT_BITS); This flag is used only in the GMP code. */ static bool dev_debug = false; -/* Like error(0, 0, ...), but without an implicit newline. - Also a noop unless the global DEV_DEBUG is set. - TODO: Replace with variadic macro in system.h or - move to a separate module. */ -static inline void -devmsg (char const *fmt, ...) -{ - if (dev_debug) - { - va_list ap; - va_start (ap, fmt); - vfprintf (stderr, fmt, ap); - va_end (ap); - } -} - /* Prove primality or run probabilistic tests. */ static bool flag_prove_primality = true; -- cgit v1.2.3-54-g00ecf