From 492dcb2eb191b844a2fd5e51db3eed85289bea1f Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Sat, 15 Oct 2016 23:10:35 +0100 Subject: all: use die() rather than error(EXIT_FAILURE) die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...); --- src/factor.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/factor.c') diff --git a/src/factor.c b/src/factor.c index ff454b485..d271de907 100644 --- a/src/factor.c +++ b/src/factor.c @@ -114,6 +114,7 @@ #include #include "system.h" +#include "die.h" #include "error.h" #include "full-write.h" #include "quote.h" @@ -2079,7 +2080,7 @@ factor_using_squfof (uintmax_t n1, uintmax_t n0, struct factors *factors) if (g <= L) { if (qpos >= QUEUE_SIZE) - error (EXIT_FAILURE, 0, _("squfof queue overflow")); + die (EXIT_FAILURE, 0, _("squfof queue overflow")); queue[qpos].Q = g; queue[qpos].P = P % g; qpos++; @@ -2363,7 +2364,7 @@ lbuf_flush (void) { size_t size = lbuf.end - lbuf.buf; if (full_write (STDOUT_FILENO, lbuf.buf, size) != size) - error (EXIT_FAILURE, errno, "%s", _("write error")); + die (EXIT_FAILURE, errno, "%s", _("write error")); lbuf.end = lbuf.buf; } -- cgit v1.2.3-70-g09d2