From a037e838e15c9a698f1634398e0fe2726398d575 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Wed, 23 Sep 2009 10:10:51 +0100 Subject: maint: Use logical rather than bitwise operators on bools This is because bitwise operators are: - confusing and inconsistent in a boolean context - non short circuiting - brittle in C89 where bool can be an int (so > 1) --- src/expand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/expand.c') diff --git a/src/expand.c b/src/expand.c index 074f7789c..afc574b3c 100644 --- a/src/expand.c +++ b/src/expand.c @@ -344,7 +344,7 @@ expand (void) error (EXIT_FAILURE, 0, _("input line is too long")); } - convert &= convert_entire_line | !! isblank (c); + convert &= convert_entire_line || !! isblank (c); } if (c < 0) -- cgit v1.2.3-54-g00ecf