From 492dcb2eb191b844a2fd5e51db3eed85289bea1f Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Sat, 15 Oct 2016 23:10:35 +0100 Subject: all: use die() rather than error(EXIT_FAILURE) die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...); --- src/dircolors.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/dircolors.c') diff --git a/src/dircolors.c b/src/dircolors.c index 0ada49423..8046ce37b 100644 --- a/src/dircolors.c +++ b/src/dircolors.c @@ -24,6 +24,7 @@ #include "system.h" #include "dircolors.h" #include "c-strcase.h" +#include "die.h" #include "error.h" #include "obstack.h" #include "quote.h" @@ -470,7 +471,7 @@ main (int argc, char **argv) syntax = guess_shell_syntax (); if (syntax == SHELL_SYNTAX_UNKNOWN) { - error (EXIT_FAILURE, 0, + die (EXIT_FAILURE, 0, _("no SHELL environment variable, and no shell type option given")); } } -- cgit v1.2.3-54-g00ecf