From 154588d7229910ae7d401a3f20433108695dae02 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 20 Apr 1999 13:24:14 +0000 Subject: (my_strtoumax): Fix typo in computing whether overflow occurred. Improve overflow-detection to use only one conditional branch total, rather than 2N+1 conditional branches for an N-digit number. --- lib/xstrtoumax.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/xstrtoumax.c') diff --git a/lib/xstrtoumax.c b/lib/xstrtoumax.c index 40f0d783a..9ef799b34 100644 --- a/lib/xstrtoumax.c +++ b/lib/xstrtoumax.c @@ -78,12 +78,12 @@ my_strtoumax (char const *ptr, char **endptr, int base) /* An implementation with uintmax_t longer than long, but with no known way to convert it. Do it by hand. Assume base 10. */ uintmax_t n = 0; - int overflow = 0; + uintmax_t overflow = 0; for (; '0' <= *ptr && *ptr <= '9'; ptr++) { uintmax_t n10 = n * 10; int digit = *ptr - '0'; - overflow |= ! (n10 / 10 == n && n10 < n10 + digit); + overflow |= n ^ (n10 + digit) / 10; n = n10 + digit; } if (endptr) -- cgit v1.2.3-54-g00ecf