From 695a0b5502a623e5a9a6d149500c4898102d2dd8 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Thu, 22 May 2014 02:16:14 +0100 Subject: maint: enforce consistent width and case of file system constants * src/stat.c (human_fstype): Adjust a couple of existing constants to be a consistent width and capitalization so that the src/fs-magic-compare target works without reporting false positives. * cfg.mk (sc_fs-magic-compare): A new syntax check to enforce this. Improved by: Jim Meyering --- cfg.mk | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'cfg.mk') diff --git a/cfg.mk b/cfg.mk index 66aa55ddd..1e884cde3 100644 --- a/cfg.mk +++ b/cfg.mk @@ -577,6 +577,14 @@ sc_marked_devdiagnostics: halt='found marked developer diagnostic(s)' \ $(_sc_search_regexp) +# Ensure we keep hex constants as 4 or 8 bytes for consistency +# and so that make src/fs-magic-compare works consistently +sc_fs-magic-compare: + @sed -n 's|.*/\* \(0x[0-9A-Fa-f]\{1,\}\) .*\*/|\1|p' \ + $(srcdir)/src/stat.c | grep -Ev '^0x([0-9A-F]{4}){1,2}$$' \ + && { echo '$(ME): Constants in src/stat.c should be 4 or 8' \ + 'upper-case chars' 1>&2; exit 1; } || : + # Override the default Cc: used in generating an announcement. announcement_Cc_ = $(translation_project_), \ coreutils@gnu.org, coreutils-announce@gnu.org -- cgit v1.2.3-54-g00ecf