From bf87a2c8ea4487ca4448c9fe42a9c9858400acbd Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Wed, 8 Apr 2009 10:43:15 +0100 Subject: id: fix infinite loop on some systems Steven Parkes reported that `id -G $USER` went into an infinite loop on Darwin systems for users in more than 10 groups: http://bugs.gentoo.org/show_bug.cgi?id=264007 * gl/lib/mgetgroups.c (mgetgroups): Work around buggy getgrouplist implementations that don't update the required size correctly, by doubling the result buffer and retrying. Also return the parameter updated by getgrouplist rather than its return value, as the documentation doesn't actually state the number of groups stored is returned by getgrouplist. * tests/misc/id-groups: Add test to exercise this logic * tests/Makefile.am: Reference new test * NEWS: Mention the fix * THANKS: Update --- THANKS | 1 + 1 file changed, 1 insertion(+) (limited to 'THANKS') diff --git a/THANKS b/THANKS index 6a918a429..fe523fe12 100644 --- a/THANKS +++ b/THANKS @@ -525,6 +525,7 @@ Steve McIntyre steve@einval.com Steve Ward planet36@gmail.com Steven G. Johnson stevenj@alum.mit.edu Steven Mocking ufo@quicknet.nl +Steven Parkes smparkes@smparkes.net Steven Schveighoffer schveiguy@yahoo.com Steven P Watson steven@magelico.net Stuart Kemp skemp@peter.bmc.com -- cgit v1.2.3-54-g00ecf