From 0cfd4f2161de5e942cbd7c273d03a90c1dfd2062 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 10 Nov 2010 13:53:38 +0100 Subject: csplit: avoid buffer overrun when writing more than 999 files Without this fix, seq 1000 | csplit - /./ '{*}' would write the NUL-terminated file name, xx1000, into a buffer of size 6. * src/csplit.c (main): Use properly sized file name buffer. * NEWS (Bug fixes): Mention it. * tests/misc/csplit-1000: New test to trigger the bug. * tests/Makefile.am (TESTS): Add misc/csplit-1000. --- NEWS | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 0cd615332..89ae5d679 100644 --- a/NEWS +++ b/NEWS @@ -9,6 +9,10 @@ GNU coreutils NEWS -*- outline -*- latent bug introduced in coreutils 8.1, and possibly a second latent bug going at least as far back as coreutils 5.97] + csplit no longer corrupts heap when writing more than 999 files. + Demonstrate with: seq 1000 | csplit - /./ '{*}' + [the bug was present in the initial implementation] + tail -F once again notices changes in a currently unavailable remote directory [bug introduced in coreutils-7.5] -- cgit v1.2.3-54-g00ecf