From ffd1a1d8dee921e20db515e7d4b3c3e47006c8b4 Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Mon, 12 May 2014 15:46:43 +0100 Subject: maint: avoid clang -Wtautological-constant-out-of-range-compare warning * src/df.c (decode_output_arg): Use only enum constants to avoid clang "warning: comparison of constant -1 with expression of type 'display_field_t' is always false" --- src/df.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/df.c b/src/df.c index a7fc57ff7..01ecca6c5 100644 --- a/src/df.c +++ b/src/df.c @@ -144,7 +144,8 @@ typedef enum IAVAIL_FIELD, /* inodes available */ IPCENT_FIELD, /* inodes used in percent */ TARGET_FIELD, /* mount point */ - FILE_FIELD /* specified file name */ + FILE_FIELD, /* specified file name */ + INVALID_FIELD /* validation marker */ } display_field_t; /* Flag if a field contains a block, an inode or another value. */ @@ -372,7 +373,7 @@ decode_output_arg (char const *arg) *comma++ = 0; /* process S. */ - display_field_t field = -1; + display_field_t field = INVALID_FIELD; for (unsigned int i = 0; i < ARRAY_CARDINALITY (field_data); i++) { if (STREQ (field_data[i].arg, s)) @@ -381,7 +382,7 @@ decode_output_arg (char const *arg) break; } } - if (field == -1) + if (field == INVALID_FIELD) { error (0, 0, _("option --output: field %s unknown"), quote (s)); usage (EXIT_FAILURE); -- cgit v1.2.3-54-g00ecf