summaryrefslogtreecommitdiff
path: root/maint.mk
AgeCommit message (Collapse)Author
2009-02-02maint: tighten atoi/atof-prohibiting regexp, clean up .x-sc- fileJim Meyering
* maint.mk (sc_prohibit_atoi_atof): Require "(" after token. * .x-sc_prohibit_atoi_atof: Remove names that no longer contain a match.
2009-02-02* maint.mk (sc_redundant_const): Use $(_prohibit_regexp).Jim Meyering
2009-01-31maint: detect useless inclusion of c-ctype.hJim Meyering
* maint.mk (sc_prohibit_c_ctype_without_use): New rule.
2009-01-29maint: teach "make syntax-check" to print each check name as it's runJim Meyering
* maint.mk (%.m): New rules to print each syntax-checking rule name, just before running its commands. ($(syntax-check-rules)): Depend on it.
2009-01-29maint: factor syntax-check rulesJim Meyering
* maint.mk (_ignore_case): New macro. (_prohibit_regexp): Use it. Factor many existing syntax-check rules to use $(_prohibit_regexp).
2009-01-26tests: generalize install-transform-checkJim Meyering
* maint.mk (install-transform-check): Generalize to work also in a project that installs manuals in a section other than "1".
2009-01-16maint: remove obsolete sc_author_mark_check ruleJim Meyering
* maint.mk (sc_author_mark_check): Remove rule. "and" no longer appears in the definition of AUTHORS.
2009-01-16maint: enforce existing prohibition: no cvs $keywords$Jim Meyering
* maint.mk (sc_prohibit_cvs_keyword): New rule.
2009-01-07* maint.mk: align some backslashesJim Meyering
2009-01-01maint: factor out common code; prohibit use of HAVE_MBRTOWCJim Meyering
* maint.mk (_prohibit_regexp): New macro. (sc_avoid_if_before_free, sc_cast_of_argument_to_free): (sc_cast_of_x_alloc_return_value, sc_cast_of_alloca_return_value): (sc_space_tab, sc_prohibit_atoi_atof, sc_prohibit_strcmp): (sc_prohibit_stat_st_blocks, sc_prohibit_S_IS_definition): Use it. (sc_prohibit_HAVE_MBRTOWC): New rule.
2009-01-01maint: use more sc_-prefixed namesJim Meyering
* maint.mk (sc_po_check): Renamed from po-check. (sc_author_mark_check): Renamed from author_mark_check. (sc_copyright_check): Renamed from copyright-check. (sc_makefile_path_separator_check): Renamed from makefile_path_separator_check. (local-checks-available): Remove the old names. * Makefile.am (EXTRA_DIST): Reflect the renaming: .x-sc_po_check * .x-po-check: Rename to... * .x-sc_po_check: ...new file.
2009-01-01maint: tighten m4 AC_ quoting checkJim Meyering
* maint.mk (sc_m4_quote_check): Renamed from m4-check. Also search for AC_DEFINE and AC_DEFINE_UNQUOTED. Also search in configure.ac. * configure.ac: Quote first argument of AC_DEFINE. * jm-macros.m4 (coreutils_MACROS): Quote the first argument to AC_DEFINE.
2009-01-01maint: move coreutils-specific syntax check rules into cfg.mkJim Meyering
* maint.mk (sc_dd_max_sym_length, sc_prohibit_jm_in_m4): (sc_root_tests, sc_always_defined_macros, sc_system_h_headers): (sc_sun_os_names, sc_tight_scope, sc_no_exec_perl_coreutils): Move rules into cfg.mk. (sc_strftime_check): Renamed from strftime-check, and moved, too. * cfg.mk: Add the above rules.
2008-12-26maint: ensure dd's computation of O_FULLBLOCK uses all O_ symbol namesJim Meyering
* src/dd.c (O_FULLBLOCK): Use a more uniform initializer, that makes it easier to extract all O_ symbol names. * maint.mk (syntax-check-rules): Also search for sc_ rules in cfg.mk. (sc_root_tests): Ensure that this rule sets $diff. * cfg.mk (sc_dd_O_FLAGS): New rule.
2008-12-21maint.mk: enforce the "include <config.h> first" ruleJim Meyering
* maint.mk (sc_require_config_h_first): New rule. * .x-sc_require_config_h_first: New file.
2008-11-30build: don't reject definition of STREQJim Meyering
* maint.mk (sc_prohibit_strcmp): Tighten rule: exclude macro definitions like the one in system.h. * .x-sc_prohibit_strcmp: Don't exempt src/system.h.
2008-10-18* maint.mk (coreutils-path-check): New definition, now runJim Meyering
only if src/true.c exists. Factored out of... (my-distcheck): ...here.
2008-10-16build: when po-check fails, say why and suggest a fixJim Meyering
* maint.mk (po-check): Before, when this check failed, it just spat out a diff mentioning two temporary files. Now, it tells you what's wrong and suggests a fix with a patch using the name of the affected file (rather than temporary file names) in the diff output.
2008-10-12tests: move check-misc targets from src/Makefile.am to maint.mkJim Meyering
* src/Makefile.am (check): Remove check-misc. (check-misc): Remove target. * maint.mk (sc_prohibit_stat_st_blocks): New target. (sc_prohibit_S_IS_definition): New target. * Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_stat_st_blocks. * .x-sc_prohibit_stat_st_blocks: New file. Andreas Schwab reported that "make check" could fail to detect violation of the no-S_IS*-definition policy.
2008-10-05* maint.mk (alpha beta major): Add "-a" to git commit ... command.Jim Meyering
2008-09-27* maint.mk (my-distcheck): remove duplicate c99-related test codeJim Meyering
2008-09-26maint: relax a check so "make distcheck" succeeds againJim Meyering
* maint.mk (makefile-check): Relax the check, in order to exempt the necessary use of a sole @...@-delimited Makefile.am variable.
2008-09-24maint: avoid using find -name Makefile.am; could get false positivesJim Meyering
* maint.mk (makefile-check): Instead, search for the offending @...@ construct only in version-controlled files.
2008-09-14various VPATH-related fixesRalf Wildenhues
* maint.mk (VC_LIST): Prepend '$(srcdir)/'. (patch-check): Fix to make it work with a VPATH build. * src/Makefile.am (sc_tight_scope): Likewise. * man/Makefile.am (.x.1): Do not make outputs unwritable.
2008-09-13tests: reenable disabled test, now that automake can handle itJim Meyering
This reverts the change in ae1c205fc473589d028ef63785926263843555cd.
2008-09-11tests: temporarily disable part of "make distcheck"Jim Meyering
* maint.mk (install-transform-check): Temporarily disable.
2008-09-10tests: use "Exit $fail", not (exit $fail); exit $failJim Meyering
* tests/test-lib.sh (Exit): New function by Ralf Wildenhues in automake http://git.sv.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=20594c08f63 * tests/**: Convert all uses: This restrictive change converted the vast majority: git grep -l '^(exit \$fail); exit \$fail$' \ | xargs perl -pi -e 's/'^\(exit \$fail\); exit \$fail$/Exit \$fail/' And this did the rest, plus a few undesirable ones, so I manually backed out the changes to ChangeLog-* and build-aux/check.mk: git grep -l -E '\(exit [^)]+\); exit ' \ | xargs perl -pi -e 's/\(exit (.+?)\); exit \1/Exit $1/'
2008-07-22tests: ensure "make check" w/tainted build dir no longer impacts $HOMEJim Meyering
* maint.mk (taint-distcheck): New rule. (maintainer-distcheck): Make it.
2008-06-26tests: adjust c99-to-c89 patch as well as the code to generate itJim Meyering
* maint.mk (patch-check) [REGEN_PATCH]: Trim some trailing blanks. * src/c99-to-c89.diff: Adjust shred.c offsets.
2008-06-26tests: fix make distcheck failure due to TODO changeJim Meyering
* maint.mk (po-check): Limit check for e.g., _(...)-marked messages to files matching *.? and *.??, thus excluding TODO and *.diff.
2008-06-20make "make syntax-check" quieterJim Meyering
* maint.mk (po-check, makefile-check, sc_proper_name_utf8_requires_ICONV): Add "@" prefix.
2008-06-17ls, od: avoid redundant constEric Blake
* src/ls.c (long_time_format, sort_functions): Avoid redundant const. * src/od.c (charname): Likewise. * maint.mk (sc_redundant_const): Add rule to detect this.
2008-06-16remove redundant const directivesJim Meyering
In 1463824d8e7f72c31f1d803d7cfe2b608ccafc5c, I added some missing "const" directives, as well as some new, redundant ones. This removes the redundant ones. Pointed out by Eric Blake. * base64.c, cat.c, chcon.c, chgrp.c, chmod.c, chown.c, comm.c: * cp.c, csplit.c, cut.c, date.c, dd.c, df.c, dircolors.c, du.c: * env.c, expand.c, fmt.c, fold.c, groups.c, head.c, id.c: * install.c, join.c, kill.c, ln.c, ls.c, md5sum.c, mkdir.c: * mkfifo.c, mknod.c, mktemp.c, mv.c, nice.c, nl.c, od.c: * paste.c, pathchk.c, pinky.c, pr.c, ptx.c, readlink.c, rm.c: * rmdir.c, runcon.c, seq.c, shred.c, shuf.c, sort.c, split.c: * stat.c, stty.c, su.c, sum.c, tac.c, tail.c, tee.c, timeout.c: * touch.c, tr.c, truncate.c, tty.c, uname.c, unexpand.c, uniq.c: * wc.c, who.c: Remove redundant const directives. * maint.mk (sc_const_long_option): Don't require redundant "const".
2008-06-14* maint.mk (sc_proper_name_utf8_requires_ICONV) Fix typo in diagnostic.Jim Meyering
2008-06-14add "const" attribute, where possibleJim Meyering
* maint.mk (sc_const_long_option): New rule. Enforce global change. * src/base64.c (long_options): Use "const" where possible. * src/cat.c (main): Likewise. * src/chcon.c (long_options): Likewise. * src/chgrp.c (long_options): Likewise. * src/chmod.c (long_options): Likewise. * src/chown.c (long_options): Likewise. * src/comm.c (long_options, OUTPUT_DELIMITER_OPTION): Likewise. * src/cp.c (long_opts): Likewise. * src/csplit.c (longopts): Likewise. * src/cut.c (longopts): Likewise. * src/date.c (long_options): Likewise. * src/dd.c (conversions, flags, statuses): Likewise. * src/df.c (long_options): Likewise. * src/dircolors.c (long_options): Likewise. * src/du.c (long_options): Likewise. * src/env.c (longopts): Likewise. * src/expand.c (longopts): Likewise. * src/fmt.c (long_options): Likewise. * src/fold.c (longopts): Likewise. * src/groups.c (longopts): Likewise. * src/head.c (long_options): Likewise. * src/id.c (longopts): Likewise. * src/install.c (long_options): Likewise. * src/join.c (longopts): Likewise. * src/kill.c (long_options): Likewise. * src/ln.c (long_options): Likewise. * src/ls.c (long_time_format, long_options, sort_functions): Likewise. * src/md5sum.c (long_options): Likewise. * src/mkdir.c (longopts): Likewise. * src/mkfifo.c (longopts): Likewise. * src/mknod.c (longopts): Likewise. * src/mktemp.c (longopts): Likewise. * src/mv.c (long_options): Likewise. * src/nice.c (longopts): Likewise. * src/nl.c (longopts): Likewise. * src/od.c (charname, long_options): Likewise. * src/paste.c (longopts): Likewise. * src/pathchk.c (longopts): Likewise. * src/pinky.c (longopts): Likewise. * src/pr.c (long_options): Likewise. * src/ptx.c (long_options): Likewise. * src/readlink.c (longopts): Likewise. * src/rm.c (long_opts): Likewise. * src/rmdir.c (longopts): Likewise. * src/runcon.c (long_options): Likewise. * src/seq.c (long_options): Likewise. * src/shred.c (long_opts): Likewise. * src/shuf.c (long_opts): Likewise. * src/sort.c (monthtab, long_options): Likewise. * src/split.c (longopts): Likewise. * src/stat.c (long_options): Likewise. * src/stty.c (mode_info, control_info, longopts, set_mode) Likewise. (set_control_char, speeds): Likewise. * src/su.c (longopts): Likewise. * src/sum.c (longopts): Likewise. * src/tac.c (longopts): Likewise. * src/tail.c (long_options): Likewise. * src/tee.c (long_options): Likewise. * src/timeout.c (long_options): Likewise. * src/touch.c (longopts): Likewise. * src/tr.c (long_options): Likewise. * src/truncate.c (longopts): Likewise. * src/tty.c (longopts): Likewise. * src/uname.c (uname_long_options, arch_long_options): Likewise. * src/unexpand.c (longopts): Likewise. * src/uniq.c (longopts): Likewise. * src/wc.c (longopts): Likewise. * src/who.c (longopts): Likewise.
2008-06-09enforce the proper_name_utf8-requires-ICONV link ruleJim Meyering
* maint.mk (sc_proper_name_utf8_requires_ICONV): New rule. * src/Makefile.am (timeout_LDADD, truncate_LDADD): Add $(LIBICONV).
2008-06-08maint.mk: my-distcheck runs $(MAKE) syntax-check once againJim Meyering
* maint.mk (my-distcheck): Run $(MAKE) syntax-check once again. Run "$(MAKE) check" _after_ the less expensive syntax-check.
2008-06-08standardize some error messagesBo Borgerson
* maint.mk: (sc_error_message_warn_fatal, sc_error_message_uppercase): (sc_error_message_period): Add automatic checks for non-standard error messages. * .x-sc_error_message_uppercase: explicit exclusion for this check * src/cp.c: Standardize some error messages. * src/date.c: Likewise. * src/dircolors.c: Likewise. * src/du.c: Likewise. * src/expr.c: Likewise. * src/install.c: Likewise. * src/join.c: Likewise. * src/ln.c: Likewise. * src/mv.c: Likewise. * src/od.c: Likewise. * src/pr.c: Likewise. * src/split.c: Likewise. * src/truncate.c: Likewise. * src/wc.c: Likewise. * tests/du/files0-from: Expect new error message. * tests/misc/join: Likewise. * tests/misc/split-a: Likewise. * tests/misc/wc-files0-from: Likewise. * tests/misc/xstrtol: Likewise. * lib/xmemxfrm.c: Likewise.
2008-06-08syntax-check: detect anachronistic Perl-based testsJim Meyering
* maint.mk (sc_no_exec_perl_coreutils): Rename and rewrite.
2008-06-03adjust c99-to-c89 patch as well as the code to generate itJim Meyering
* maint.mk (patch-check) [REGEN_PATCH]: Eliminate date-related differences in generated diffs. * src/c99-to-c89.diff: Adjust offsets.
2008-06-03use gnulib's progname moduleJim Meyering
* bootstrap.conf (gnulib_modules): Add progname. * src/*.c (program_name): Remove declaration. * (main): Call set_program_name rather than setting program_name. * src/nice.c (main): Cast program_name to "(char *)". * src/prog-fprintf.c: Include "system.h" * src/system.h: Include "progname.h". * maint.mk (sc_program_name): Adjust rule. Suggestion from Eric Blake.
2008-06-02each file with a "main" must also declare program_nameJim Meyering
* maint.mk (sc_program_name): New rule. * .x-sc_program_name: New file. * Makefile.am (EXTRA_DIST): Add .x-sc_program_name.
2008-06-01add rules to commit three post-release changes automaticallyJim Meyering
* maint.mk (noteworthy): Define. (emit-commit-log): Define. (alpha beta major): Also update NEWS and cfg.mk automatically, and commit all three changes at once.
2008-06-01adjust format of .prev-version commit messageJim Meyering
* maint.mk (alpha beta major): Start with "*", omit version number.
2008-05-27tests: generalize my-distcheckJim Meyering
* maint.mk (my-distcheck): Accommodate missing gnulib-tests.
2008-05-26test installation results more thoroughlyJim Meyering
* maint.mk (my-distcheck): Ensure that properly-named binaries are installed. Also check all man pages, except [.1. Move configure-time --prefix= to install-time prefix=. (my-instcheck, install-transform-check): Define.
2008-05-06tests: detect and check more uses of strcmpJim Meyering
* maint.mk (sc_prohibit_strcmp): Relax regexp to recognize other formatting styles.
2008-04-28tests: slightly relax sc_cast_of_argument_to_free syntax checkJim Meyering
* maint.mk (sc_cast_of_argument_to_free): Relax regexp slightly. (sc_no_have_config_h): Add a comment.
2008-04-22build: move a project-specific definition to cfg.mkJim Meyering
* cfg.mk (old_NEWS_hash): Define here, ... * maint.mk: ... not here. (update-NEWS-hash): Update comment. Suggestion from Eric Blake.
2008-04-22guard against inserting a NEWS entry into a block for a prior releaseJim Meyering
Without a guard like this, it is far too easy to apply a patch prepared against a preceding release, and not notice that a NEWS entry is inserted into the wrong block. * maint.mk (sc_immutable_NEWS): New rule. (update-NEWS-hash): New rule to update the hard-coded hash.