summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2007-12-01Defer NEWS and ChangeLog checks until after the version-changing tag.Jim Meyering
* Makefile.maint (alpha beta major): Don't depend on the news-date-check changelog-check targets. They must fail before applying the version-changing tag. Instead, run them after "vc-dist".
2007-12-01* NEWS: Mention some of the SELinux changes.Jim Meyering
Record release date and new version number. * src/stat.c (main): Adjust a comment.
2007-12-01TODO: Add entries (documentation needed); remove the "add mktemp program" one.Jim Meyering
2007-12-01Add "extern" keyword to declaration of cp_options_default.Jim Meyering
* src/copy.c (cp_options_default): Mark as "extern", so the "sc_tight_scope" part of "make distcheck" passes.
2007-12-01Change comments: say bug present up to coreutils-6.9, not fixed in 6.10.Jim Meyering
* tests/cut/Test.pm: Adjust comment. * tests/misc/cut: Likewise. * tests/misc/ls-misc: Likewise. * tests/misc/od: Likewise. * tests/misc/stty-invalid: Likewise. * tests/tr/Test.pm: Likewise.
2007-12-01Add a test for cp -p and existing file permissions.Paul Eggert
* tests/cp/Makefile.am (TESTS): Add existing-perm-race. * tests/cp/existing-perm-race: New test. It isn't much of a test yet, since it's hard to catch the race, but it has a FIXME that will let us do a better test later.
2007-12-01Fix a security race with "cp -p A B" when B already exists.Paul Eggert
* src/copy.h (struct cp_options): New member owner_privileges. * src/copy.c (USE_ACL): Define to 0 if not defined, for convenience. (owner_failure_ok): New function. (set_owner): Avoid a security-related race by doing an extra chmod first if it looks like there might be trouble right after a chown. Accept a source struct stat rather than a uid and gid, and accept a boolean NEW_DST and destination struct stat. All callers changed. * src/copy.h (cp_options_default): New function, replacing the old chown_privileges. * src/copy.c (cp_options_default): Likewise. * src/cp.c (cp_option_init): Use it. * src/install.c (cp_option_init): Likewise. * src/mv.c (cp_option_init): Likewise.
2007-11-30Avoid a spurious test failure when build directory is set-GID.Jim Meyering
* tests/cp/fail-perm: Ensure that '.'s set-GID bit is off.
2007-11-30Be extra careful to quote $abs_top_builddir-derived names.Jim Meyering
* tests/misc/ls-misc (shell_quote): New function. Use it to quote file names derived from $abs_top_builddir, in case it contains shell meta-characters. This is not currently needed, since CuTmpdir detects the fishy name and skips the test. But it's important enough to add the extra protection. Reported by Ralf Wildenhues.
2007-11-30Include test name in the "unsafe working directory name" diagnostic.Jim Meyering
* tests/CuTmpdir.pm (import): If $ME is '-', use $prefix.
2007-11-30Add quotes to protect against white space in build dir name.Ralf Wildenhues
* tests/check.mk (TESTS_ENVIRONMENT): Quote $(abs_srcdir). * tests/chmod/setgid: Quote absolute names. * tests/misc/help-version: Likewise. * tests/misc/pwd-unreadable-parent: Likewise. * tests/rmdir/ignore: Likewise. * tests/test-lib.sh: Likewise.
2007-11-30Define `tst', for CU_TEST_NAME.Ralf Wildenhues
* build-aux/check.mk (am__check_pre): Set `tst', for CU_TEST_NAME in tests/check.mk.
2007-11-30* tests/CuTmpdir.pm (END): Do not do the cleanup if $dir is notRalf Wildenhues
defined, because it then goes wild and changes the mode of all directories below $HOME. Undefined $dir can happen if the test is to be skipped because of an unsafe working directory name.
2007-11-29Close a file descriptor leak when cp --preserve=context fails.Paul Eggert
* src/copy.c (copy_reg): Close dest_desc too, if getfscreatecon or fsetfilecon fail.
2007-11-28README: Document the known problem with gettext <= 0.17.Jim Meyering
2007-11-28* gl/modules/randread (Depends-on): Remove nonexistent rand-isaac.Paul Eggert
2007-11-27Don't block use of 'cat' or 'wc' in "make check".Jim Meyering
* Makefile.maint (my-distcheck): Add "cat" and "wc" to the list of programs that we can't blacklist.
2007-11-27Fix md5sum+sha*sum on sparc: regenerate files with latest autoconf.Jim Meyering
* configure et al: Regenerate with very latest version of autoconf (v2.61a-312-gb524b0f), to fix md5sum and sha*sum miscompilation on big-endian systems (like sparc) due to lack of the required definition in of WORDS_BIGENDIAN in lib/config.h.
2007-11-26setuidgid.c: more cleanupJim Meyering
* src/setuidgid.c: Include "mgetgroups.h". (main): Don't presume there's a fixed limit on the maximum number of group IDs. Don't use NGROUPS; it's artificially low. Change the name of a local: s/gids_count/n_gids/. Remove non-portable "const": s/const int tmp =.../int tmp =.../
2007-11-25Document install's -D option.Jim Meyering
* doc/coreutils.texi (install invocation): Document -D. Reported by Akim Demialle.
2007-11-25setuidgid: Update --help output.Jim Meyering
* src/setuidgid.c (usage): Describe -g GID[,GID1...] option. Mention that USER may be a numeric ID or a user name.
2007-11-24Tweak new test.Jim Meyering
* tests/cp/preserve-gid: Split some long lines. Prepend "+" to numeric uid and gid chown arguments, on principle. Use skip_test_.
2007-11-24setuidgid: minor clean-up.Jim Meyering
* setuidgid.c: Include "xstrtoul.h". (main): Detect overflow in string-to-gid_t and -to-uid_t conversions. Improve diagnostics.
2007-11-24setuidgid.c: Normalize leading white space: no more TABsJim Meyering
2007-11-24Test the new feature: cp -p preserves the GID whenever possible.Lasse Collin
* tests/cp/preserve-gid: New file. Test for today's change. * tests/cp/Makefile.am (TESTS): Add preserve-gid. * tests/Makefile.am (all_t): Add tc. (tc): New target.
2007-11-24setuidgid: accept numeric UID, and new option -g GID,GID1,GID2,...Lasse Collin
* src/setuidgid.c: Add functionality for the new test above.
2007-11-24"cp -p" tries to preserve GID even if preserving the UID fails.Lasse Collin
* NEWS: Mention this new feature. * src/copy.c (set_owner): Try to preserve just the GID, when initial fchown/lchown fails. * src/cp.c (re_protect): Likewise.
2007-11-23* src/runcon.c (main): Remove unused parameter, "envp".Jim Meyering
2007-11-23Add tests to show new class of strings accepted by date -d.Jim Meyering
* tests/misc/date (rel-1day, rel-plus1): New tests for the recent change in gnulib's getdate.y. * NEWS: Mention the fix.
2007-11-22Quiet warnings about unused parameters.Jim Meyering
* src/copy.c (set_author) [!HAVE_STRUCT_STAT_ST_AUTHOR]: "Use" each of the parameters.
2007-11-22* GNUmakefile: Correct the "rerunning..." diagnostic.Jim Meyering
2007-11-22Make it easier to diagnose PATH-induced "make distcheck" failures.Jim Meyering
* Makefile.maint (write_loser): Define. (my-distcheck): Use an always-failing wrapper script, that gives a diagnostic, not "false". Run only "make -C tests check" with the restrictive PATH. Run the new gnulib-tests/ with the usual PATH.
2007-11-22cp: by default, refuse to copy through a dangling destination symlinkJim Meyering
* NEWS: Mention this change. * doc/coreutils.texi (cp invocation): Describe the new behavior. * src/copy.c: No longer include "canonicalize.h". (copy_reg): Upon failure to open a dangling destination symlink, don't canonicalize the name, but rather fail (default) or, with POSIXLY_CORRECT, repeat the open call without O_EXCL (potentially dangerous). * src/copy.h (struct cp_options) [open_dangling_dest_symlink]: New member. Reorder the others, grouping "bool" and "enum" members together. * tests/cp/thru-dangling: Test for changed and new behavior. * src/cp.c (cp_option_init): Initialize new member. * src/install.c (cp_option_init): Likewise. * src/mv.c (cp_option_init): Likewise. Signed-off-by: Jim Meyering <meyering@redhat.com>
2007-11-21Fix Pádraig's name in ChangeLog.Jim Meyering
2007-11-21Improve the descriptions of the split command options.Pádraig Brady
* doc/coreutils.texi (split invocation):
2007-11-21* src/c99-to-c89.diff: Adjust seq.c offsets.Jim Meyering
2007-11-21* src/seq.c (print_numbers): Rewrite in an attempt to avoid thePaul Eggert
more-general rounding issues exposed by the previous patch.
2007-11-18* src/c99-to-c89.diff: Adjust seq.c offsets.Jim Meyering
2007-11-18Remove unused parameter in remove.c.Jim Meyering
* src/remove.c (fd_to_subdirp): Remove unused parameter. (remove_cwd_entries, remove_dir): Update callers.
2007-11-18bootstrap: work also with 4-argument variant of AC_INIT (from gnulib)Jim Meyering
2007-11-18 Sergey Poznyakoff <gray@gnu.org.ua> * bootstrap (gnulib_extra_files): Adjust sed command.
2007-11-17Correct preceding patch.Jim Meyering
* src/seq.c (print_numbers): Also handle first < last && step < 0. * tests/misc/seq [empty-rev]: New test for this case.
2007-11-17"seq .1 .1" would mistakenly generate no output on some systemsJim Meyering
* NEWS: Say this. * src/seq.c (print_numbers): Handle another floating point corner case. This avoids failure of seq's eq-wid-7 test on FreeBSD 6.1.
2007-11-17Port tests/rmdir/ignore away from GNU/Linux.Paul Eggert
* tests/rmdir/ignore: Don't assume that rmdir($PWD) will fail with errno==ENOTEMPTY when $PWD is not empty; Posix also allows rmdir to fail with errno==EBUSY.
2007-11-16Avoid an obscure new "make distcheck" failure.Jim Meyering
* Makefile.maint (my-distcheck): Also allow 'mv', for its use in gnulib-tests/Makefile.
2007-11-16Port readlink-fp-loop to Solaris.Paul Eggert
* tests/misc/readlink-fp-loop (symlink_loop_msg): New var, which records the symlink-loop message, whose wording is not standardized by Posix. Do not rely on "echo x > p/1" to work when p/1 has a lot of indirect symlinks. (I'm surprised that it works on Linux. Perhaps a Linux bug?)
2007-11-16Port to Solaris 'make' and use a Posixish shell on Solaris.Jim Meyering
* bootstrap.conf (gnulib_modules): Add gnu-make, posix-shell. * build-aux/check.mk (SHELL): Set to $(PREFERABLY_POSIX_SHELL), so that commands can assume Posix syntax. (ENABLE_HARD_ERRORS, TEST_LOGS): Don't use GNU Make's "?=" syntax. (SH_E_WORKAROUND): New macro. (am__check_pre, $(TEST_SUITE_LOG)): Use it. (am__check_pre): Fail if "mkdir" fails. Use $(SHELL) rather than relying on the "#!/bin/sh" in the file, so that tests can use Posix syntax. (am__check_pre, am__tty_colors): Use $$src rather than $$<, to support the Posix-make $(TEST_LOGS) rule. (%.log: %.test, %.log: %$(EXEEXT)): Remove unused inference rules that rely on a GNU Make extension and cause Solaris 'make' to fail. (SUFFIXES): New macro, so that we can use Posix style inference rules. (%.log: %): Use this rule only if GNU_MAKE. Set $$src so that macros can use $$src rather than $$<. (CHECK-FORCE, DEPENDENCY, $(TEST_LOGS)): New macros and rules, which rely only on Posix 'make' semantics, and are used only with non-GNU 'make' implementations. $(TEST_LOGS) invokes 'make' recursively (and a bit inefficiently) to simulate the GNU 'make' rules. (.log.html): Renamed from "%.html: %.log", so that it relies only on Posix 'make' semantics. (check-clean, .PHONY): Do not depend on check-clean-local, since Solaris 'make' complains about nonexistent rules like that. * src/Makefile.am (SUFFIXES): Remove; no longer needed. (groups): Use a specific rule rather than an inference rule that is only instantiated once. The inference-rule approach does not work with Solaris 'make', which gets confused by the "groups: Makefile" line. It's not clear from the Posix spec that Solaris 'make' is buggy here, so instead of worrying about it, rewrite the makefile so that it clearly conforms to Posix. * tests/check.mk (TESTS_ENVIRONMENT): Export PACKAGE_BUGREPORT. GNU 'make' does this automatically for us, but Solaris 'make' doesn't. 2007-11-15 Paul Eggert <eggert@cs.ucla.edu>
2007-11-16Port to Solaris 8 perl, which does not support "use warnings;".Paul Eggert
* tests/dd/skip-seek: Skip test if "use warnings;" fails. * tests/du/files0-from: Likewise. * tests/misc/base64: Likewise. * tests/misc/basename: Likewise. * tests/misc/cut: Likewise. * tests/misc/date: Likewise. * tests/misc/dircolors: Likewise. * tests/misc/dirname: Likewise. * tests/misc/expand: Likewise. * tests/misc/expr: Likewise. * tests/misc/factor: Likewise. * tests/misc/fmt: Likewise. * tests/misc/fold: Likewise. * tests/misc/head-elide-tail: Likewise. * tests/misc/ls-misc: Likewise. * tests/misc/md5sum: Likewise. * tests/misc/md5sum-newline: Likewise. * tests/misc/mktemp: Likewise. * tests/misc/od: Likewise. * tests/misc/paste-no-nl: Likewise. * tests/misc/pr: Likewise. * tests/misc/seq: Likewise. * tests/misc/sha1sum: Likewise. * tests/misc/sha1sum-vec: Likewise. * tests/misc/sha224sum: Likewise. * tests/misc/sha256sum: Likewise. * tests/misc/sha384sum: Likewise. * tests/misc/sha512sum: Likewise. * tests/misc/sort-merge: Likewise. * tests/misc/stat-printf: Likewise. * tests/misc/sum: Likewise. * tests/misc/test-diag: Likewise. * tests/misc/tsort: Likewise. * tests/misc/unexpand: Likewise. * tests/misc/wc-files0-from: Likewise. * tests/misc/xstrtol: Likewise. * tests/mv/i-1: Likewise. * tests/rm/empty-name: Likewise. * tests/rm/unreadable: Likewise.
2007-11-15* m4/include-exclude-prog.m4 (gl_REMOVE_PROG): Fix syntax error.Andreas Schwab
Remove trailing space from result.
2007-11-15Avoid misbehavior of a cross-device "mv" or "install".Jim Meyering
Those programs must not dereference a destination symlink. * src/copy.c (copy_reg): Don't treat a dangling destination symlink differently in move mode. In move mode, the only way the added O_EXCL can cause failure is when some other process has recreated the file this code unlinked a few instructions before.
2007-11-14Another bootstrap kludge.Jim Meyering
* bootstrap: Ensure gnulib-tests/test-*.sh are executable
generated by cgit v1.2.3-70-g09d2 (git 2.47.1) at 2024-12-28 18:54:34 +0000