summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-03-27tests: avoid spurious test failure in set-GID build dirJim Meyering
* tests/install/install-C-root: Skip this test if in set-gid directory. Reported by Sven Joachim and C de-Avillez.
2009-03-27tests: migrate setgid-check into test-lib.shJim Meyering
* tests/test-lib.sh (skip_if_setgid_): New function. * tests/setgid-check: Remove file. * tests/Makefile.am (EXTRA_DIST): Remove setgid-check. * tests/chmod/c-option: Use the new function rather than sourcing the separate file. * tests/cp/cp-parents: Likewise. * tests/install/install-C: Likewise. * tests/mkdir/parents: Likewise. * tests/mkdir/perm: Likewise.
2009-03-26tests: mark the rm/ext3-perf test as "very" expensiveJim Meyering
* tests/rm/ext3-perf: Relegate this test to the very_expensive category, since it is failing too often for me, when run in parallel (-j4) with other disk-hammering tests. This test fails when it takes too long, so the fact that it fails under pressure is an inconvenience more than a real problem.
2009-03-26* gnulib: Update submodule to latest.Jim Meyering
2009-03-26df: port the known-value fix to AIX as wellPaul Eggert
* src/df.c (known_value): New function, which also works on AIX /proc file systems. (df_readable, show_dev): Use it instead of hardcoding comparison to UINTMAX_MAX. Suggested by Jim Meyering and Matthew Woehlke.
2009-03-26df: fix a bug when totaling unknown valuesPaul Eggert
* src/df.c (show_dev): Don't add UINTMAX_MAX to grand totals, as that value indicates that the true value is unknown; adding it effectively subtracts 1 from the total, whereas we want to leave the total alone.
2009-03-25tests: don't fail "make syntax-check" on cygwinJim Meyering
* maint.mk (NEWS_hash): Remove trailing " -" or " *-". * cfg.mk (old_NEWS_hash): Regenerate, removing " -". Reported by Eric Blake.
2009-03-25pwd: support -L and -PEric Blake
* src/pwd.c (longopts): New variable. (logical_getcwd): New function. (main): Use it. (usage): Document new options. * doc/coreutils.texi (pwd invocation): Likewise. * NEWS: Likewise. * TODO (pwd): Mark it done. * tests/misc/pwd-option: New file. * tests/Makefile.am (TESTS): Add test. * THANKS: Update. Reported by Paul D. Smith, in savannah bug 24949.
2009-03-25doc: update suffix regex in version sortOndřej Vašík
* doc/coreutils.texi: Reflect current filevercmp regex.
2009-03-25tests: CuTmpdir.pm: avoid use of undefined variable in warningRalf Wildenhues
* tests/CuTmpdir.pm (chmod_tree): Do not warn if $dir is undefined.
2009-03-24tests: ls -v: exercise yet another change in gnulib's new filevercmpJim Meyering
* tests/misc/ls-misc: Add names with ~ and ~.1~ suffixes.
2009-03-24* gnulib: Update submodule to latest.Jim Meyering
2009-03-24ls: make it possible to disable coloring of hard linksKamil Dudka
* src/ls.c (print_color_indicator): Don't color hard links if disabled (when there is an empty hl= in the LS_COLORS environment variable). * tests/ls/hardlink: Add test case for disabled hard link highlighting. * NEWS: Mention the change.
2009-03-21tests: search only files that are under version controlJim Meyering
* maint.mk (sc_error_exit_success): Search only files that are under version control. (sc_makefile_path_separator_check): Likewise. Check *.mk files, too, not just Makefile.am files.
2009-03-21tests: follow own advice: use $(PATH_SEPARATOR), not ":"Jim Meyering
* maint.mk (coreutils-path-check): Use the variable, not the literal.
2009-03-21tests: modernize: use $(var) makefile notation, not @var@Jim Meyering
* maint.mk (sc_makefile_path_separator_check): Recommend the use of $(PATH_SEPARATOR), not @PATH_SEPARATOR@. Remove an obsolete comment.
2009-03-20tests: teach sc_dd_O_FLAGS about new syntax in dd.cJim Meyering
* cfg.mk (sc_dd_O_FLAGS): Adapt to new syntax.
2009-03-20dd: use a more portable definition of O_FULLBLOCKEric Blake
* src/dd.c (O_FULLBLOCK): Compute its value without using a 180KB macro. This avoids triggering a compilation failure with HP-UX's cc. Reported by Matthew Woehlke.
2009-03-20tests: avoid spurious mkdir/selinux test failure on HP-UX 11.23Jim Meyering
* tests/mkdir/selinux: Accept yet another diagnostic. Reported by Matthew Woehlke.
2009-03-19tests: df/total-verify: avoid test failure with older PerlJim Meyering
* tests/df/total-verify: Don't use perl's -f option. Reported by Matthew Woehlke.
2009-03-19* gnulib: Update submodule to latest.Jim Meyering
2009-03-18tests: adjust sort-continue not to fail under valgrindJim Meyering
* tests/misc/sort-continue: Don't run cat inside fd-limited shell. If sort fails to run in an fd-limited shell, skip the test.
2009-03-18tests: add another sort/nmerge testPaul Eggert
* tests/Makefile.am (TESTS): Add sort-merge-fdlimit. * tests/misc/sort-merge-fdlimit: New file. * doc/coreutils.texi (sort invocation): Document that we now silently lower nmerge if necessary. Patch by Paul Eggert, Nima Nikzad, Max Chang, Alexander Nguyen, Sahil Amoli, and Nick Graham.
2009-03-18sort: handle fd exhaustion better when mergingPaul Eggert
This is an alternative to my 9 March patch labeled "Silently lower nmerge; don't (sometimes incorrectly) range-check" <http://lists.gnu.org/archive/html/bug-coreutils/2009-03/msg00070.html>. It differs by not using 'dup' to probe for extra file descriptors; instead, it simply calls 'open' (and 'pipe') to open files and pipes, until one of these calls fails due to file descriptor exhaustion; it then backs off by 1, does a merge with the files that it has opened, and then retries with the (now-smaller) number of files. This patch requires quite a few more changes to the source code than the earlier patch, but it is in some sense "better" because it doesn't need to call "dup" ahead of time in order to decide whether "open" or "pipe" will fail. Also, it's more robust in the case where "open" or "pipe" fails with errno==EMFILE because some system-wide limit is exhausted. * src/sort.c (create_temp_file): New arg SURVIVE_FD_EXHAUSTION. (stream_open): New function, containing guts of xfopen. (xfopen): Use it. (pipe_fork): Set errno on failure. (maybe_create_temp): New function, containing guts of create_temp. (create_temp): Use it. (open_temp): Distinguish failures due to file descriptor exhaustion from other failures, and on fd exhaustion return a notice to caller rather than dying. Don't test execlp's return value; when it returns, it *always* returns -1. (open_input_files): New function. (mergefps): New arg FPS. It's now the caller's responsibility to open the input and output files. All callers changed. (mergefiles): New function. (avoid_trashing_input, merge): Handle the case where a single merge can't merge as much as we wanted due to file descriptor exhaustion, by merging as much as we can and then retrying. * tests/Makefile.am (TESTS): Add misc/sort-continue. * tests/misc/sort-continue: New file. * THANKS: Add Glen Lenker and Matt Pham who coauthored this patch.
2009-03-18maint: normalize leading-TAB indentation in MakefilesJim Meyering
* maint.mk (sc_makefile_TAB_only_indentation): New rule. Replace each TAB+8-space sequence with two TABs. * man/Makefile.am: Likewise. * build-aux/check.mk: Likewise. I used this command (run it more than once, if needed): t=$'\t'; git grep -l -E "$t {8}"|grep -E 'Makefile|\.mk$' \ | xargs perl -pi -e 's/\t {8}/\t\t/'
2009-03-15maint: remove long-unused MakefileJim Meyering
* tests/sort-time/Makefile: Remove long-unused file.
2009-03-15maint: remove unused include and definitionsJim Meyering
* gl/lib/randread.c (__attribute__): Remove unused definition. (ATTRIBUTE_UNUSED): Likewise. * gl/lib/selinux-at.c (_): Remove unused definition. Don't include <gettext.h>. No longer needed.
2009-03-15* gnulib: Update submodule to latest.Jim Meyering
2009-03-14system.h: correct compilation error: MAX not definedJim Meyering
* src/system.h (io_blksize): Move definition down, so it follows that of MAX -- to avoid compilation failure on OpenSolaris. Reported by David Bartley. Details in http://lists.gnu.org/archive/html/bug-coreutils/2009-03/msg00190.html
2009-03-14* gnulib: Update to pull in select/interix work-around.Jim Meyering
2009-03-13doc: update "version sort" documentationKamil Dudka
* doc/coreutils.texi: Reflect current filevercmp behavior.
2009-03-12tests: groups-version: don't require that id be builtJim Meyering
* tests/misc/groups-version: groups is now independent of id.
2009-03-12tests: skip the groups-dash test when "groups" is not builtJim Meyering
* tests/misc/groups-dash: Skip if groups is not being installed. Suggested by Mike Frysinger. Also fail if groups exits with nonzero status.
2009-03-12maint: mention Autoconf version required to build AutomakePádraig Brady
* README-prereq: coreutils currently requires an unreleased version of Automake, so mention the minimum version of Autoconf required to build that. Suggestion from James Youngman.
2009-03-12* gnulib: Update submodule to latest.Jim Meyering
2009-03-11cp: make -a option preserve xattrs, but with reduced diagnosticsOndřej Vašík
* copy.c (copy_attr_by_fd): Reduce xattr diagnostics for 'cp -a'. (copy_attr_by_name): Likewise. * cp.c (main): Preserve xattrs with -a option, when possible. * doc/coreutils.texi: Document that xattrs are preserved with cp -a, with no added diagnostics. * NEWS: Mention the change. * tests/misc/xattr: Add tests for 'cp --preserve=all' and 'cp -a'.
2009-03-11maint: Document how to best to enable gcc warnings for developersPádraig Brady
* README-hacking: Mention --enable-gcc-warnings configure option * configure.ac: Don't scare developers away from using gcc warnings
2009-03-11maint: remove an obsolete FIXME commentJim Meyering
* src/Makefile.am (../AUTHORS): Remove obsolete FIXME comment. There are no longer any installed *.sh programs.
2009-03-11cat: Fix immediate output of processed dataPádraig Brady
Introduced by commit 790892db, 2006-06-08 "Ensure that cat works ...". * NEWS: Mention the bugfix. * src/cat.c (cat): Fix the typo which stopped the writing of processed data before a blocking read() is done. * tests/misc/cat-buf: Add to ensure processed data is not buffered. * tests/Makefile.am: Reference the new test.
2009-03-11cat,cp,mv,install,split: Set the minimum IO block size used to 32KiBPádraig Brady
This is following on from this change: [02c3dc9d 2008-03-06 cat: use larger buffer sizes ...] which increased the IO block size used by cat by 8 times, but also capped it at 32KiB. * NEWS: Mention the change in behavior. * src/system.h: Add a new io_blksize() function that returns the max of ST_BLKSIZE or 32KiB, as this was seen as a good value for a minimum block size to use to get good performance while minimizing system call overhead. * src/cat.c: Use it. * src/copy.c: ditto * src/split.c: ditto
2009-03-08tests: add a test for newly-fixed bug in comm --check-orderJim Meyering
* tests/misc/comm (ooo-prefix): Add a test for today's fix. * NEWS (Bug fixes): Mention it.
2009-03-08comm: fix a bug in its new --check-order optionBruno Haible
* src/comm.c: Include memcmp2.h. (check_order): Use memcmp2 instead of memcmp. * bootstrap.conf (gnulib_modules): Add memcmp2.
2009-03-08tests: ls -v: exercise the bug fixed by gnulib's new filevercmpJim Meyering
* tests/misc/ls-misc (version-sort): New test. (mk_file): New function. Reported by Josh Triplett in <http://bugs.debian.org/517558>. Details in http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/16902 * NEWS (Bug fixes): Mention it.
2009-03-08gnulib: sync submodule to latestJim Meyering
2009-03-07pr: fix a bug whereby --indent=N (-o) did not indent header linesJim Meyering
* src/pr.c (print_header): Honor chars_per_margin also for the header. Inspired by a patch from C de-Avillez. This change also adjusts two other %*s directives to be %*.*s instead, (for the padding on either side of "file_text") to correct a bug that could make pr print one space of padding instead of none. * NEWS (Bug fixes): Mention it. * tests/pr/o3Jml24f-lm-lo: Adjust for new expected output. * tests/pr/o3a3Sl24f-tn: Likewise. * tests/pr/o3a3Snl24f-tn: Likewise. * tests/pr/o3a3l24f-tn: Likewise. * tests/pr/o3b3Sl24f-tn: Likewise. * tests/pr/o3b3Snl24f-tn: Likewise. * tests/pr/o3b3l24f-tn: Likewise. * tests/pr/o3mSl24f-bl-tn: Likewise. * tests/pr/o3mSnl24fbltn: Likewise. * tests/pr/o3ml24f-bl-tn: Likewise.
2009-03-07bootstrap: add to XGETTEXT_OPTIONSJim Meyering
* bootstrap.conf (XGETTEXT_OPTIONS): Add c-format --flag options for verror and verror_at_line; alphabetize.
2009-03-07maint: use a git submodule for gnulibJim Meyering
* .gitmodules: New file, to track gnulib. * gnulib: New file, created by running this: git submodule add git://git.sv.gnu.org/gnulib.git gnulib
2009-03-07build: allow ./bootstrap --srcdir=... to work with a git submoduleJim Meyering
* bootstrap (git_modules_config): Use GIT_CONFIG, not GIT_CONFIG_LOCAL. The latter was removed in v1.5.6.1-109-gdc87183.
2009-03-07build: avoid "multiply defined..." warning from automakeJim Meyering
* Makefile.am (AM_CFLAGS): Add $(WARN_CFLAGS) via +=, not =, to avoid "multiply defined..." warning from automake.
2009-03-06cat: use larger buffer sizes to reduce read/write-syscall overheadJim Meyering
* src/cat.c (max): Remove definition. Use MAX from system.h instead. (compute_buffer_size): New function to compute the input and output buffer sizes, which are now set at 8 times st_blksize with a maximum of 32KiB. Previously the typical block sizes used were 1KiB for pipes and 4KiB for files, and now will be 8KiB and 32KiB respectively. (main): Use it. This change can double throughput on modern systems. For timings, see http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/16040 Suggestion from Tzvi Rotshtein.