summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-09-01timeout: defensive handling of all wait() errorsPádraig Brady
* src/timeout.c (main): Handle all possible cases of unexpected failures from wait(). This was prompted by the clang tool reporting the possible non-initialization of the status variable.
2009-09-01ls -i: print consistent inode numbers also for mount pointsJim Meyering
On most unix- and linux-based kernels, ls -i DIR_CONTAINING_MOUNT_POINT would print the wrong inode number for any entry that is a mount point. It would do that by relying on readdir's dirent.d_ino values, while most readdir implementations return the inode number of the underlying, inaccessible directory. Thus, it is not consistent with what you'd get when applying stat to the same entry. This bug led to surprising results like "ls -i" and "ls -i --color" printing different numbers (ls must usually "stat" a file to colorize its name). This change makes it so that on offending systems, ls must stat non-command-line-arguments for which otherwise it would be able to use "for free" dirent.d_ino values. Regardless of this change, ls is already required to stat every command-line argument. Note: versions of GNU ls prior to coreutils-6.0 did not perform the invalid optimization, and hence always printed correct inode numbers. Thus, for the sake of correctness, ls -i is forgoing the readdir optimization, for any kernel (including linux!) with POSIX-nonconforming readdir. Note that currently, only Cygwin has been agile enough to conform. * src/ls.c (RELIABLE_D_INO): Define. (print_dir): Use it. For plenty of discussion, see this long thread: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/14020 This bug was introduced by the 2006-02-26 commit, 33eb3efe: "In ls, avoid calling stat for --inode (-i), when possible." * tests/ls/readdir-mountpoint-inode: New test. * tests/Makefile.am (TESTS): Add it. * tests/ls/stat-vs-dirent: Don't suppress failure of this test, now that ls -i is fixed. Though note that it doesn't test well, since it compares only the always-stat'd command-line arguments. * NEWS (Bug fixes): Mention it.
2009-08-31maint: revert my stdbuf change: the result didn't even compileJim Meyering
This reverts commit c1e158489d88bad418d52ceadf37af0b6f5b2112.
2009-08-30maint: stdbuf: move a declaration; no-semantic-changeJim Meyering
* src/stdbuf.c (set_program_path): Move a declaration down into the scope where it's used.
2009-08-30build: quiet "make check" in src/Jim Meyering
* src/Makefile.am (check-duplicate-no-install): Use $(AM_V_GEN). (check-README): Likewise. And $(AM_V_at).
2009-08-30doc: cp: update note on preserving symlink time stampsJim Meyering
* doc/coreutils.texi (cp invocation): Now, we *do* preserve time stamps on symlinks, when possible.
2009-08-30build: update bootstrap from gnulibJim Meyering
* bootstrap: Merge from gnulib.
2009-08-30tests: don't misbehave if $TMPDIR contains spacesPádraig Brady
* tests/misc/xattr: Add quotes. * tests/mv/acl: Likewise. * tests/mv/backup-is-src: Likewise. * tests/mv/hard-link-1: Likewise. * tests/mv/leak-fd: Likewise. * tests/mv/mv-special-1: Likewise. * tests/mv/part-fail: Likewise. * tests/mv/part-hardlink: Likewise. * tests/mv/part-rename: Likewise. * tests/mv/part-symlink: Likewise. * tests/mv/partition-perm: Likewise. * tests/mv/sticky-to-xpart: Likewise.
2009-08-29tests: other-fs-tmpdir: don't misbehave for quote-unfriendly $TMPDIRJim Meyering
* tests/other-fs-tmpdir: Quote uses of variables that might expand to strings containing e.g., whitespace.
2009-08-29build: update from gnulibJim Meyering
* gnulib: Update submodule to latest.
2009-08-29tests: move a coreutils-specific test from maint.mk to Makefile.amJim Meyering
* Makefile.am (distcheck-hook): Make taint-distcheck here, since it's no longer done via maint.mk.
2009-08-29tests: cp/reflink-auto guard against a pathological $TMPDIRJim Meyering
* tests/cp/reflink-auto: Add quotes.
2009-08-29cp --reflink: preserve attributes on cloned files if askedPádraig Brady
* src/copy.c (copy_reg): When cloning only skip the data copying * tests/cp/reflink-perm: New test to check times and modes copied * tests/Makefile.am: Reference the new test * NEWS: Mention the fix
2009-08-29cp --reflink: add an "auto" parameter to fall back to a normal copyPádraig Brady
* doc/coreutils.texi (cp invocation): Document the new "auto" and "always" options to --reflink. * src/copy.c (copy_reg): Fall back to a standard copy when reflink() is not supported and --reflink=auto specified. * src/copy.h [struct cp_options] (reflink): Change type s/bool/enum/. * src/cp.c (usage): Describe the --reflink={always,auto} options and expand a little on what --reflink does. (main): parse the new parameters to --reflink and allow all --sparse options with --reflink=auto. * src/install.c (cp_option_init): Init the enum instead of bool. * src/mv.c (cp_option_init): Likewise. * tests/cp/reflink-auto: A new test for falling back to normal copy. * tests/Makefile.am: Reference the new test. * NEWS: Mention the new feature.
2009-08-28stdbuf: fix a small typo in --help outputPádraig Brady
* src/stdbuf.c (usage): s/then/the/
2009-08-28build: avoid unused variable warnings on cygwinEric Blake
* src/copy.c (clone_file, copy_attr_by_fd, copy_attr_by_name): Mark up unused variables. * src/remove.c (dirent_inode_sort_may_be_useful): Likewise.
2009-08-28dd: detect closed stderrEric Blake
* src/dd.c (maybe_close_stdout): Always flush stderr; regression introduced in commit 381e69ea. * tests/misc/close-stdout (p): Use consistent style. * tests/dd/stderr: New test, borrowing from misc/close-stdout. * tests/Makefile.am (TESTS): Run it. * NEWS: Mention this.
2009-08-28maint: ignore only man/*.1, not all *.1 filesJim Meyering
* .gitignore: Ignore *.1 only in man/
2009-08-27build: prefix a few rules with $(AM_V_GEN)Jim Meyering
* Makefile.am (.version, dist-hook, gen-ChangeLog): Use $(AM_V_GEN) and $(AM_V_at), so that automake's silent-rules option (make V=1/V=0) now controls whether the commands are printed at build time. (THANKS-to-translators, check-ls-dircolors): Likewise.
2009-08-26build: stop earlier if touching ChangeLog failsJim Meyering
* bootstrap.conf: Exit right away if touching ChangeLog fails. Otherwise, the touch failure message is buried under configure output.
2009-08-26tests: mkdir/selinux: avoid spurious failure on some SELinux systemsJim Meyering
* tests/test-lib.sh (require_selinux_enforcing_): New function. * tests/mkdir/selinux: Use it. Otherwise, this test would fail on Rawhide with SELinux disabled.
2009-08-26tests: tail-2/assert: avoid risk of race conditionJim Meyering
* tests/tail-2/assert: Avoid spurious failure due to race condition. Rather than sleeping for 1 second and crossing fingers, wait explicitly for backgrounded tail process to start. Otherwise, this test would fail under heavy load.
2009-08-25maint: ensure we don't embed Emacs indent-tabs-mode setting linesJim Meyering
Now that we prohibit indentation via TABs, there's no need for Emacs indent-tabs-mode setting lines, so prohibit those, too. * cfg.mk (sc_prohibit_emacs__indent_tabs_mode__setting): New rule.
2009-08-25maint: remove Local Variables: indent-tabs-mode: nil from all sourcesJim Meyering
* src/getlimits.c: Likewise. * src/group-list.c: Likewise. * src/groups.c: Likewise. * src/mktemp.c: Likewise. * src/setuidgid.c: Likewise. * src/stdbuf.c: Likewise. * src/timeout.c: Likewise. * src/truncate.c: Likewise. * gl/lib/mbsalign.c: Likewise. * tests/test-lib.sh: Likewise. * bootstrap: Likewise. * README-hacking: Likewise.
2009-08-25doc: HACKING: mention the new space-only indentation policyJim Meyering
2009-08-25maint: teach "make syntax-check" the space-only indentation ruleJim Meyering
* cfg.mk (sc_prohibit_tab_based_indentation): New rule. * .x-sc_prohibit_tab_based_indentation: New file. * Makefile.am (syntax_check_exceptions): Add file, .x-sc_prohibit_tab_based_indentation.
2009-08-25global: convert indentation-TABs to spacesJim Meyering
Transformed via this shell code: t=$'\t' git ls-files \ | grep -vE '(^|/)((GNU)?[Mm]akefile|ChangeLog)|\.(am|mk)$' \ | grep -vE 'tests/pr/|help2man' \ | xargs grep -lE "^ *$t" \ | xargs perl -MText::Tabs -ni -le \ '$m=/^( *\t[ \t]*)(.*)/; print $m ? expand($1) . $2 : $_'
2009-08-24cp: ignore obscure failure to preserve symlink time stamps,Jim Meyering
...when run on a kernel older than what was implied by headers and libraries tested at configure time. * src/copy.c (utimens_symlink): Ignore failure when errno == ENOSYS. * NEWS (Bug fixes): Mention it. Reported by Todd Zullinger and Kamil Dudka. Details in this thread: http://thread.gmane.org/gmane.linux.redhat.fedora.devel/119834
2009-08-23tests: skip (don't fail) a cp test, upon mount-related failureJim Meyering
* tests/cp/cp-mv-enotsup-xattr: Upon a set-up failiure, rather than failing the test with a "framework failure" diagnostic, just skip it. Russell Whitaker reported that this test failed on slackware.
2009-08-23build: update from *public* gnulibJim Meyering
* gnulib: Update submodule to latest. Kamil Dudka reported that bootstrap was broken.
2009-08-22build: update from gnulibJim Meyering
* gnulib: Update submodule to latest.
2009-08-20post-release administriviaJim Meyering
* NEWS: Add header line for next release. * .prev-version: Record previous version. * cfg.mk (old_NEWS_hash): Auto-update.
2009-08-20version 7.5Jim Meyering
* NEWS: Record release date.
2009-08-20tests: skip the stdbuf tests when the abs build directory name is bogusJim Meyering
* tests/misc/stdbuf: Avoid spurious failure when the directory name from which we'd set LD_PRELOAD contains unsafe characters.
2009-08-20install: avoid a portability bug when compiling with non-gccJim Meyering
* src/install.c (extra_mode): Be careful to return only a 0 or 1 value, since this is a "bool" function, and there are still some compilers for which this is necessary. Without this change, Bernhard Voelker reported that the Forte Developer 7 C 5.4 2002/03/09 compiler would produce a malfunctioning "install" binary. Details in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/17710/focus=17760
2009-08-19tests: make install-C slightly less prone to confusionJim Meyering
* tests/install/install-C: Invoke framework_failure, if necessary.
2009-08-19build: avoid "make dist" failure in man/Jim Meyering
Now that "make check" no longer builds programs like arch, ... * src/Makefile.am (dist-hook): Depend on $(all_programs), so that the subsequent build in man/ doesn't fail due to lack of a program like arch that is not going to be installed.
2009-08-18build: update from gnulibJim Meyering
* gnulib: Update submodule to latest.
2009-08-18nl: deprecate --page-increment in favor of --line-incrementGiuseppe Scrivano
* NEWS: Mention the change. * doc/coreutils.texi: Document the new --line-increment option. * src/nl.c (struct option): Add --line-increment, (usage): Describe it, (main): Use it.
2009-08-18tests: stdbuf: fix a bug in test scriptJim Meyering
* tests/misc/stdbuf: Use skip_test_ only after it's defined. Reported by Berhnard Voelker. (sc_check-AUTHORS): Rename rule from check-AUTHORS.
2009-08-18build: perform check-AUTHORS via syntax-check, not via "make check"Jim Meyering
* src/Makefile.am (check): Don't depend on check-AUTHORS. That check fails on systems for which a program like stdbuf is not built. Instead, move this check to "make syntax-check". (sc_check-AUTHORS): Rename rule from check-AUTHORS. * cfg.mk (sc_check-AUTHORS): New rule. Reported by Berhnard Voelker.
2009-08-18sort: use more portable initialization syntaxJim Meyering
* src/sort.c (find_unit_order): Spell out 256-element static initializer, rather than relying on C99 syntax. Required for Forte Developer 7 C 5.4 2002/03/09 on Solaris 10. Reported by Bernhard Voelker.
2009-08-17build: suppress warnings due to gcc's new -Wjump-misses-initJim Meyering
* configure.ac: Ignore -Wjump-misses-init violations in remove.c.
2009-08-17build: update from gnulibJim Meyering
* gnulib: Update submodule to latest.
2009-08-16tests: tail-2/append-only: don't discard stderrJim Meyering
* tests/tail-2/append-only: Don't discard a diagnostic that may help explain why this test fails for some. Details in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/17621/focus=17641
2009-08-14tests: skip the misc/stdbuf test if stdbuf was not builtJim Meyering
* tests/misc/stdbuf: Skip this test when stdbuf is not built. Reported by Eric Blake.
2009-08-14build: use gnulib's getopt-gnu module (getopt is now deprecated)Jim Meyering
* bootstrap.conf (gnulib_modules): Gnulib's getopt module is now deprecated; use the new, preferred name, getopt-gnu. * gnulib: Update to latest.
2009-08-14cp,mv: fix issues with preserving timestamps of copied symlinksPádraig Brady
* src/copy.c (copy_internal): On systems without utimensat don't use utimens on a symlink, as that would dereference the symlink. * tests/cp/abuse: To work around possible attribute preservation failures breaking the test, use cp -dR rather than cp -a.
2009-08-14doc: clarify the cp --reflink NEWSPádraig Brady
* NEWS: Remove the description associated with the removed experimental code which unconditionally tried to reflink() on copy. Also clarify where --reflink works exactly.
2009-08-13tests: raise ulimit virt-mem limit to avoid new failureJim Meyering
* tests/cp/link-heap: Raise limit from 16MB to ~20MB, to avoid spurious failure on rawhide.
generated by cgit v1.2.3-70-g09d2 (git 2.48.0) at 2025-01-16 17:46:12 +0000