summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2008-04-14seq: work around floating point inaccuracies on more systemsJim Meyering
* src/seq.c: Include <math.h> for fabs. Include <float.h> for DBL_EPSILON. (abs_rel_diff): New function. (print_numbers): Use abs_rel_diff rather than a strict equality test. Without this change, Solaris 8 and Irix 6.2 would fail the float-6 test. Reported by Peter Fales in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13183 * src/c99-to-c89.diff: Adjust seq.c offsets.
2008-04-14doc: fix typoJim Meyering
* coreutils.texi (sort invocation): s/Whitespace/White space/
2008-04-12tests: Accommodate a different errno value on OSF/1 4.0F.Jim Meyering
* tests/mkdir/selinux: Also handle "Function not implemented".
2008-04-12Avoid link failure when using mkstemp replacement.Jim Meyering
* src/Makefile.am (tac_LDADD): Add $(LIB_CLOCK_GETTIME). This is necessary at least on a DEC Alpha OSF/1 4.0F.
2008-04-12tests: always enable VERBOSE output, now that test framework works betterJim Meyering
* cfg.mk: Set VERBOSE=yes. * tests/check.mk: Likewise.
2008-04-11doc: avoid "make pdf" failure (due to texi2dvi bug?)Jim Meyering
* doc/coreutils.texi (filesZeroFromOption): Comment out @cindex-in-@macro use.
2008-04-11doc: use a valid texinfo macro nameJim Meyering
* doc/coreutils.texi (filesZeroFromOption): s/0/Zero/
2008-04-08tests: accommodate a different errno value on HPUX-10.20Jim Meyering
* tests/mkdir/selinux: Also handle "Unknown system error". Reported by Peter Fales.
2008-04-06doc: factor out --files0-from duplicationJim Meyering
* coreutils.texi (wc invocation) [files0fromOption]: New macro. Use it. (du invocation): Use it here, too.
2008-04-06* src/c99-to-c89.diff: Adjust remove.c diffs.Jim Meyering
2008-04-06remove.c: accommodate systems with negative errno valuesJim Meyering
This is required at least on Haiku and BeOS. * src/remove.c (write_protected_non_symlink): Return 1 for a write- protected non-symlink, 0 if we determine it's not, and -1 upon error (setting errno accordingly only in this final case). (prompt): Deal with the changed semantics of the above function. Based on this patch from Axel Dörfler: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13071
2008-04-05Accommodate building on OS/2 (www.ecomstation.com Ecs v2 rc4)Jim Meyering
* configure.in: Also filter out carriage returns from the value of $no_install_progs_default. Reported by Elbert Pol.
2008-04-02"touch E; mkfifo F; cp -fR F E" no longer fails due to existing EJim Meyering
* src/copy.c (copy_internal): Revert change of 2005-03-01, 4303f0454592421eea48be87777d32a49e1d5e5b Prompted by Michael Stone, who pointed me to an old bug report from Ian Jackson: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/7504 * tests/cp/special-f: New file. Test for the above. * tests/cp/Makefile.am (TESTS): Add special-f. * NEWS: mention this bug fix.
2008-04-02copy.c: remove an in-function #ifdefJim Meyering
* src/copy.c (rpl_mkfifo) [! HAVE_MKFIFO]: New function. (mkfifo) [! HAVE_MKFIFO]: Define to rpl_mkfifo. (copy_internal): Remove #ifdef. Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-04-02HACKING: rename README-contribution-guidelinesJim Meyering
README-contribution-guidelines: Rename to .. HACKING: ...this.
2008-04-01bootstrap: remove dangling *.[ch] symlinks from libJim Meyering
* bootstrap [dangling symlink removal]: Match *.[ch] files, too. Suggestion from Eric Blake.
2008-04-01bootstrap: make find's -depth option be the first.Jim Meyering
* bootstrap [dangling symlink removal]: Move find's -depth option to precede all others, to avoid a warning.
2008-04-01* bootstrap: Remove dangling symlinks from lib (aka $source_base), too.Jim Meyering
2008-04-01Avoid root-only SELinux-related test failures w/o mcstransd.Jim Meyering
When mcstransd is not running (i.e., after service mcstrans stop), "make check" as root would provoke two test failures. * tests/cp/cp-a-selinux: Use the context, root:object_r:tmp_t:s0, that works both with and without mcstransd. Thanks to Eric Paris for the tip and to Ondřej Vašík for alerting me to the problem. Reported by Robert Scheck in <http://bugzilla.redhat.com/436717>.
2008-04-01root tests: Set NON_ROOT_USERNAME if not set already.Jim Meyering
* tests/test-lib.sh (require_root_): This avoids failure of a couple of root-only tests that require a value for that envvar.
2008-04-01texinfo formatting tweaksJim Meyering
* coreutils.texi: Avoid some overfull hbox warnings. (Treating / specially): Use @file{/} rather than a bare /.
2008-04-01printf doc: xref print(3) and libc's "Output Conversion Syntax" nodeJim Meyering
* coreutils.texi (printf invocation): Add xref. Use "The GNU C Library Reference Manual" as the name of the 'libc' document consistently. * man/printf.x: Add See also: printf(3). Suggested by A. Costa in http://bugs.debian.org/465522
2008-03-31Emit "#line 1" right after the two 'read-only/GENERATED' lines.Jim Meyering
* bootstrap (cp_mark_as_generated): This preserves line numbering e.g., in assertions, which is important when correlating between coreutils test failures and the original files in gnulib/tests. Suggested by Eric Blake.
2008-03-31* README-contribution-guidelines: Mention how to amend a commit.Jim Meyering
Suggestion from Pádraig Brady.
2008-03-31Begin documenting contribution guidelines.Jim Meyering
* README-contribution-guidelines: New file. For now, not distributed.
2008-03-31"rm -r DIR" would mistakenly prompt about very long namesJim Meyering
* src/remove.c (write_protected_non_symlink): Return 0(-1) when euidaccess_stat pronounces a writable(not-writable) file, not -1(0). * tests/rm/deep-2: New file. Test for the above-fixed bug. * tests/rm/Makefile.am (TESTS): Add deep-2. Discovered while reviewing this change: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13071
2008-03-31* NEWS: Note the dd bug fix. The bug was introduced over 8 years ago:Jim Meyering
9fca49f67c16c8b42c32e185808fe187cedb0fa7
2008-03-31dd bug fix: accept e.g., if=/dev/stdin and of=/dev/stdoutPaul Eggert
* lib/fd-reopen.c: Work even if FILE is "/dev/stdin". Problem reported by Geoffrey Lee in <http://bugs.debian.org/290727>. * tests/dd/misc: Check for this bug.
2008-03-29avoid failure of new test on kernel without SELinux supportJim Meyering
* tests/mkdir/selinux: Also accept ENOENT. Reported by Sven Joachim. Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-03-29tests: accept ENOTSUP message as well as the EINVAL oneJim Meyering
This test would fail on most non-Linux systems because the original expected an "Invalid argument" diagnostic, yet they all produced "Operation not supported". * tests/mkdir/selinux: Accept both strings. Factor out duplication.
2008-03-29Work around a recent glibc/getopt.c diagnostic change.Jim Meyering
* tests/misc/factor: Map new "-- '1'" to expected "-- 1". Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-03-28mknod, mkfifo: don't segfault when diagnosing invalid SELinux contextJim Meyering
Identical to the bug fixed by 72d052896a9092b811961a8f3e6ca5d151a59be5. * src/mkfifo.c (main): Use "scontext", not NULL optarg in diagnostic. * src/mknod.c (main): Likewise. Reported by Cristian Cadar, Daniel Dunbar and Dawson Engler. * tests/mkdir/selinux: Test for the above fixes. * NEWS: Mention the fixes.
2008-03-28Fix typo in old NEWS and ChangeLog: s/commmand/command/.Jim Meyering
* ChangeLog-2007: Likewise. * NEWS: Likewise. Prompted by http://bugzilla.redhat.com/439410
2008-03-28tests: Factor out code that's going to be reused.Pádraig Brady
* tests/test-lib.sh (mkfifo_or_skip_): New function, factored out of... * tests/touch/fifo: ...here.
2008-03-28Require that "(exit $fail); exit $fail" be last line of each test.Jim Meyering
* maint.mk (sc_require_test_exit_idiom): New rule to enforce policy. * tests/cp/acl: Adhere to the new policy. * tests/cp/preserve-gid: Likewise. * tests/dd/misc: * tests/install/create-leading: * tests/ln/sf-1: * tests/ls/symlink-slash: * tests/misc/help-version: * tests/misc/ls-time: * tests/misc/nice: * tests/misc/shred-remove: * tests/misc/stty: * tests/misc/stty-row-col: * tests/mkdir/p-1: * tests/mkdir/p-2: * tests/mkdir/p-3: * tests/mkdir/p-v: * tests/mkdir/special-1: * tests/mkdir/writable-under-readonly: * tests/mv/acl: * tests/mv/backup-is-src: * tests/mv/diag: * tests/mv/dir-file: * tests/mv/force: * tests/mv/hard-link-1: * tests/mv/i-2: * tests/mv/i-4: * tests/mv/into-self: * tests/mv/into-self-2: * tests/mv/into-self-3: * tests/mv/partition-perm: * tests/mv/to-symlink: * tests/rmdir/ignore: * tests/tail-2/assert: * tests/tail-2/assert-2: * tests/touch/dangling-symlink: * tests/touch/dir-1: * tests/touch/empty-file: * tests/touch/fifo: * tests/touch/no-rights: Likewise. Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-03-28Perform explicit exit-nonzero if the embedded Perl script fails.Jim Meyering
* tests/misc/pwd-long: Add canonical '(exit $fail); exit $fail'. Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-03-27paste -d\\: avoid heap overrun for backslash at end of delim listJim Meyering
* src/paste.c: Include "quotearg.h". (collapse_escapes): Handle backslash-escaped backslash explicitly. Handle unescaped backslash at end of string by returning nonzero, rather than by overrunning memory. (main): Diagnose an invalid delimiter list -- carefully. Reported by Cristian Cadar, Daniel Dunbar and Dawson Engler. * tests/misc/paste-no-nl (delim-bs): Add a test to demonstrate the heap-smashing capability. (delim-bs2): Prior to coreutils-5.1.2, this bug was a little harder to demonstrate: it would corrupt a first-argument containing e.g., \b * NEWS: Mention the bug fix. * tests/misc/Makefile.am (TESTS): Reflect renaming. * tests/misc/paste: Rename from paste-no-nl. Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-03-26* src/join.c (keycmp): Document new parameters.Jim Meyering
2008-03-26Test for mkdir bug fix.Jim Meyering
* tests/mkdir/selinux: New file: test for today's fix. * tests/mkdir/Makefile.am (TESTS): Add selinux.
2008-03-26mkdir -Z x d: don't segfault when diagnosing invalid context "x" (tiny change)Daniel Dunbar
* src/mkdir.c (main): Use "scontext", not NULL optarg in diagnostic. Reported by Cristian Cadar, Daniel Dunbar and Dawson Engler. * NEWS: Mention the bug fix.
2008-03-25id bug fix: don't point to potentially clobbered static storagePeter Fales
On at least Mac OS, when calling getpwuid twice with the same UID, the static storage containing results from the first call is invalidated by the second call. * src/id.c (main): Point to a copy of the user name string.
2008-03-25Use new gnulib gnumakefile module.Eric Blake
* bootstrap.conf (gnulib_modules): Pull in new module. * GNUmakefile: Remove from version control. * .gitignore: Update. * configure.ac (AC_CONFIG_LINKS): Delete; rely on gnulib to do this now. * Makefile.am (EXTRA_DIST, distclean-local): Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>
2008-03-25join bug fix: adapt keycmp to work with new order-checking featureJim Meyering
* src/join.c (keycmp): Add two join-field parameters. (check_order, join): Update callers. Reported by Dmitry V. Levin in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/12731/focus=13017 * tests/join/Test.pm (chkodr-7): New test for this fix.
2008-03-23join.c: syntax/style tweaksJim Meyering
* src/join.c (check_order): Rename from checkorder. Move definition to precede first use and remove prototype. Use EXIT_FAILURE, rather than "1". (key_cmp): Move definition to precede first use.
2008-03-22portability: work around a "busybox sed" limitationJim Meyering
* configure.ac: While every other sed tested supports usage like '/\(re\)/{s//\1/;...<NEWLINE>}', and POSIX appears to requires this, busybox's sed does not support it. So duplicate the regexp: '/\(re\)/{s/\(re\)/\1/;...<NEWLINE>}'. Reported by Vincent Lefevre: <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13013>.
2008-03-21* src/c99-to-c89.diff: Adjust seq.c offsets.Jim Meyering
2008-03-21ptx: avoid heap overrun for backslash at end of optarg stringJim Meyering
* src/ptx.c (copy_unescaped_string): Ignore a lone backslash at end of string. Reported by Cristian Cadar, Daniel Dunbar and Dawson Engler. Details here: <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13005>. * tests/misc/Makefile.am (TESTS): Add ptx-overrun. * tests/misc/ptx-overrun: New file. Test for the above fix. * NEWS: Mention the fix. Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-03-21ptx.c readabilityJim Meyering
* src/ptx.c (copy_unescaped_string): Add braces around 80+-line single-stmt while-loop body. Signed-off-by: Jim Meyering <meyering@redhat.com>
2008-03-21Write NEWS and update c99-to-c89 patch for today's rm improvement.Jim Meyering
* NEWS: call this a "portability improvement" ;-) * src/c99-to-c89.diff: Adjust remove.c offsets.
2008-03-21remove.c: Accommodate systems with negative errno values.Ingo Weinhold
* src/remove.c (cache_fstatat): Store errno value directly in the st_ino field, rather than trying to shoehorn it into st_size. This is required at least on BeOS and Haiku.