summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2006-12-20"cut -f 2- A B" no longer triggers a double-free bugJim Meyering
* src/cut.c (cut_fields): Set file-scoped global to NULL after freeing it. This avoids a double-free (and core dump on some systems) for this usage: "echo 1>a; echo 2>b; cut -f2- a b". Reported by James Hunt in <http://bugzilla.redhat.com/220312>. * NEWS: List this bug fix. * THANKS: Mention him. * tests/misc/cut: New file. * tests/misc/Makefile.am (TESTS): Add cut.
2006-12-15* tests/cp/open-perm-race: Correct the gdb-existence check.Jim Meyering
Don't run either subsequent gdb command in a sub-shell. Reported by Thomas Schwinge. * THANKS: bring up to date.
2006-12-15Make sure cp -p isn't too generous with file permissions.Paul Eggert
* tests/cp/Makefile.am (TESTS): Add file-perm-race. * tests/cp/file-perm-race: New file. Signed-off-by: Jim Meyering <jim@meyering.net>
2006-12-15Ensure cp -pR --parents isn't too generous with parent permissions.Paul Eggert
* tests/cp/Makefile.am (TESTS): Add parent-perm-race. * tests/cp/parent-perm-race: New file. Signed-off-by: Jim Meyering <jim@meyering.net>
2006-12-14* tests/chgrp/default-no-deref: Don't assume that files are createdJim Meyering
with the primary group by default. That's not true in a directory with the set-GID bit set.
2006-12-14Don't hang when there's no input tty.Jim Meyering
* tests/cp/open-perm-race: Skip this test if there is no controlling input `terminal'.
2006-12-14Test for a hard-to-detect race fix, using gdb.Jim Meyering
* tests/cp/open-perm-race: New file, to test for the cp --preserve=ownership fix of 2006-12-06. * tests/cp/Makefile.am (TESTS_ENVIRONMENT): Define abs_top_builddir. (TESTS): Add open-perm-race.
2006-12-14chgrp, chown: Don't prohibit -RLh, aka -RL with --no-dereference.Jim Meyering
* src/chgrp.c (main): Don't prohibit -RLh, aka -RL with --no-dereference. * src/chown.c (main): Likewise. * src/chown-core.c (change_file_owner): Add to a comment. * tests/chown/preserve-root: Add tests. * doc/coreutils.texi (Treating / specially): With --preserve-root, chgrp and chown will not modify "/", even through a symlink.
2006-12-14* NEWS: --preserve-root now works with chgrp, chmod, and chown.Jim Meyering
* src/chmod.c (process_file): Do honor the --preserve-root option. * src/chown-core.c (change_file_owner): Likewise, but here, also handle the case in which a traversal would go "through" a symlink to root. Reported by Matthew M. Boedicker * tests/chown/preserve-root: Test for the above. * tests/chown/Makefile.am (TESTS): Add preserve-root.
2006-12-14* coreutils.texi: Remove two doubled words.Jim Meyering
2006-12-14* NEWS: Mention the chmod fix induced by the recent change to gnulib's ↵Jim Meyering
openat.m4.
2006-12-13Don't fail if mv/acl test succeeds.Andreas Schwab
* tests/mv/acl (skip): Check for acl support in the file system. * tests/mv/Makefile.am (XFAIL_TESTS): Remove. (TESTS_ENVIRONMENT): Pass CONFIG_HEADER. Signed-off-by: Jim Meyering <jim@meyering.net>
2006-12-13Remove some arbitrary restrictions on size fields,Paul Eggert
so that commands like "sort -k 18446744073709551616" no longer fail merely because 18446744073709551616 doesn't fit in uintmax_t. The trick is that these fields can all be treated as effectively infinity; their exact values don't matter, since no internal buffer can be that long. * src/join.c (string_to_join_field): Verify that SIZE_MAX <= ULONG_MAX if the code assumes this. Silently truncate too-large values to SIZE_MAX, as the remaining code will do the right thing in this case. * src/sort.c (parse_field_count): Likewise. * src/uniq.c (size_opt, main): Likewise. * tests/join/Test.pm (bigfield): New test. * tests/sort/Test.pm (bigfield): New test. * tests/uniq/Test.pm (121): New test. Signed-off-by: Jim Meyering <jim@meyering.net>
2006-12-13* tests/chgrp/default-no-deref: New test.Jim Meyering
* tests/chgrp/Makefile.am (TESTS): Add default-no-deref.
2006-12-12* jm-macros.m4: Remove AC_FUNC_SETVBUF_REVERSED, now that it's a no-op.Jim Meyering
2006-12-12* src/system.h (SETVBUF): Remove definition, now that theJim Meyering
autoconf macro, AC_FUNC_SETVBUF_REVERSED, does nothing. * src/tee.c (tee_files): s/SETVBUF/setvbuf/. * src/od.c (open_next_file): Likewise.
2006-12-09* man/Makefile.am (.x.1): Make help2man use $(PACKAGE_STRING) as theJim Meyering
"source". I.e. "GNU coreutils 6.7".
2006-12-09* NEWS: With the change from "-pre" to "-dirty" suffix, also changeJim Meyering
from NEXT_VER-pre to CUR_VER-dirty. So, this is 6.7-dirty. * configure.ac (AC_INIT): s/6.8-dirty/6.7-dirty/.
2006-12-09* tests/uniq/Test.pm (test_vector): Skip the pipe-reading testJim Meyering
whenever uniq is expected to fail. This should catch the other case [test #112] in which uniq emits "cat: write error: Broken pipe" on some systems.
2006-12-08Include bootstrap tool version info in the announcement form.Jim Meyering
* Makefile.maint (gnulib_snapshot_date): Define. (announcement): Use two new announce-gen options, --bootstrap-tools and --gnulib-snapshot-date. * Makefile.cfg (gnulib_dir): Set.
2006-12-08Post-release version change.Jim Meyering
* NEWS: Add a line for 6.8-dirty. * configure.ac (AC_INIT): Set new version string.
2006-12-08.prev-version: Record previous version: 6.7.Jim Meyering
2006-12-08Version 6.7.Jim Meyering
* NEWS: Record release date. Remove '-pre' suffix. * configure.ac (AC_INIT): Remove version string suffix.
2006-12-07* tests/touch/empty-file: Use envvar-check, so "make check" doesn'tJim Meyering
evoke diagnostics like this when COLUMNS=0 in the environment: ls: ignoring invalid width in environment variable COLUMNS: 0 * tests/touch/no-rights: Likewise. * tests/help-version: Likewise.
2006-12-07Make the output of "make check" more reproducible.Jim Meyering
* tests/uniq/Test.pm: Don't perform the pipe-reading version of test 118, since it emits "cat: write error: Broken pipe" on some systems.
2006-12-07cp -p now clears special bits if it fails to preserve owner or groupPaul Eggert
* NEWS: Document the cp -p fix for special bits. * src/copy.c (set_owner): Now returns a three-way result, so that the caller can clear the special bits. All callers changed. (copy_reg): Don't set the special bits if chown failed. (copy_internal): Likewise. * tests/cp/special-bits: Test this fix. Signed-off-by: Jim Meyering <jim@meyering.net>
2006-12-06* NEWS: Document the cp --preserve=ownership fix.Paul Eggert
* m4/jm-macros.m4 (coreutils_MACROS): Check for fchmod. * src/copy.c (fchmod_or_lchmod): New function. (copy_reg): New arg OMITTED_PERMISSIONS. All uses changed. Omit confusing and unused ", dst_mode" arg to 'open' without O_CREAT. When creating a file, use O_EXCL, so we're more likely to detect funny business by other processes. At the end, if permissions were omitted, chmod them back in. (copy_internal): If the ownership might change, omit some permissions at first, then restore them after chowning the file. * src/cp.c (make_dir_parents_private): Likewise. * src/copy.c (cached_umask): New function. * src/copy.h (cached_umask): New decl.
2006-12-06Make the output of "make check" more reproducible.Jim Meyering
* tests/misc/date-sec: Don't emit any diagnostic about sleeping.
2006-12-06NEWS: the du bug affects coreutils-6.4, 6.5 and 6.6.Jim Meyering
2006-12-04install.c: Preserve time stamps before changing owner or file mode bits,Paul Eggert
for consistency with other coreutils programs.
2006-12-03* Makefile.am (libcoreutils_a_SOURCES): Remove xmemcoll.c andJim Meyering
xmemcoll.h. Now, they're handled by the gnulib xmemcoll module.
2006-12-03* tests/misc/date-sec: Output a fixed string.Jim Meyering
2006-12-03Add "Reported by"Jim Meyering
2006-12-03* NEWS: du --one-file-system (-x) would skip subdirectories of anyJim Meyering
directory listed as second or subsequent command line argument. * tests/du/one-file-system: New file. Test for today's fts.c fix. * tests/du/Makefile.am (TESTS): Add one-file-system.
2006-12-02* tests/du/basic: Generate 4KB file simply using printf, rather thanJim Meyering
seq+head. This avoids a spurious "Broken pipe" diagnostic from seq.
2006-11-28* perm.texi (Mode Structure): Fix typo: s/setgid/setuid/.Jim Meyering
Reported by Georg Neis as Debian bug 400778.
2006-11-28* tests/mv/no-target-dir: Detect a buggy rename syscall. If found,Jim Meyering
skip this test. This happens at least on ia64 linux-2.4.19 w/ext3. Reported by Matthew Woehlke.
2006-11-28* tests/mv/dir2dir: Also accept EBUSY.Jim Meyering
Reported by Matthew Woehlke.
2006-11-27* Makefile.maint (patch-check): Rewrite to diagnose failure.Jim Meyering
* src/c99-to-c89.diff: Adjust shred.c offsets.
2006-11-27Improve the check for departures from C89, and fix the departuresPaul Eggert
I found. * Makefile.maint (my-distcheck): Also check for C89 compatibility as best we can with GCC. * src/stat.c (PRINTF_OPTION): Omit comma before } in enum declaration; C89 doesn't allow this. * src/dcgen: Don't generate string literals longer than what C89 requires support for. * src/cut.c (usage): Don't use string literals longer than what C89 requires support for. * src/date.c (usage): Likewise. * src/dd.c (usage): Likewise. * src/du.c (usage): Likewise. * src/ls.c (usage): Likewise. * src/od.c (usage): Likewise. * src/readlink.c (usage): Likewise. * src/seq.c (usage): Likewise. * src/shred.c (usage): Likewise.
2006-11-27recognize new archive, audio, image formats; give audio files a separate colorMike Frysinger
* src/dircolors.hin: Add comments for common .sh and .csh scripts. Add .bz2, .tbz2, .tz, .rar, .ace, .zoo, .cpio, .7z, .rz as archive suffixes. Add .mng, .pcx, .m2v, .mkv, .ogm, .mp4, .m4v, .mp4v, .vob, .qt, .nuv, .wmv, .asf, .rm, .rmvb, .flc, .yuv as image formats. Add .aac, .au, .mid, .midi, .mka, .ra as audio suffixes. Change audio color to 00;36 to differentiate from image/video color.
2006-11-26* Makefile.maint (patch-check): Compile patched sources withJim Meyering
CFLAGS='-Wdeclaration-after-statement -Werror', to ensure that no violations remain.
2006-11-26* src/c99-to-c89.diff: Remove 3 bogus hunks.Jim Meyering
2006-11-26* src/remove.c (fd_to_subdirp): Remove unused parameter, ds.Jim Meyering
Update callers.
2006-11-26* src/c99-to-c89.diff: Adjust for changes in rm.c and in remove.c.Jim Meyering
2006-11-26* src/rm.c (main): Remove unnecessary (assuming C99) braces.Jim Meyering
2006-11-26Reflect that these are Paul's changes. I've divided them into separateJim Meyering
deltas. Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
2006-11-26Port parts of the code to C89 to minimize the need for c99-to-c89.diff,Paul Eggert
while trying to retain the readability of C99 as much as possible. * src/remove.c (close_preserve_errno): Remove. (fd_to_subdirp): Rewrite to avoid the need for decl after statement. Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
2006-11-26* src/remove.c (rm): Move cycle_check_init call into callee...Paul Eggert
Use an else clause in place of a "continue" statement. Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
2006-11-26* src/remove.c (AD_ensure_initialized): New function.Paul Eggert
after statement. Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>