summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2008-08-14mktemp, sort, tac: don't use undefined after mkstemp failureJim Meyering
When mkstemp fails, the template buffer may have undefined contents, so we must not print it. * src/sort.c (create_temp_file): Use temp_dir, not "file" when diagnosing failed mkstemp, because "file" may be undefined. * tests/misc/sort-merge: Adjust for new expected output. Jeph Cowan and Ralf Wildenhues reported the test failure: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/14235/focus=14257 * src/tac.c (copy_to_temp): Don't use template buffer after failed mkstemp call, since its contents may be undefined. * tests/misc/tac (pipe-bad-tmpdir): New test for the above. * src/mktemp.c (main): Save a copy of the template string, solely for use in case mkstemp fails. * tests/misc/mktemp (pipe-bad-tmpdir): New test for the above.
2008-08-12kill: micro grammar nit in description of SIGNALBenno Schulenberg
2008-08-12groups: let synopsis show that the command allows multiple usernamesBenno Schulenberg
Also make the docstring say so.
2008-08-12id: remove superfluous condition test; it is caught at -Z aboveBenno Schulenberg
2008-08-12id: gettextize a few missed tiny stringsBenno Schulenberg
2008-08-12fmt: remove the 'no file' sentence; the standard phrase is given belowBenno Schulenberg
Replace the sentence with a more useful explanation of -DIGITS.
2008-08-11echo: correct description of \cBenno Schulenberg
* src/echo.c (usage): Correct description of \c. * coreutils.texi (echo invocation): Likewise. * src/echo.c: Remove --help-duplicating comment.
2008-08-11doc: the quote operator for expr is '+', not 'quote'Benno Schulenberg
2008-08-11factor: remove duplicate docstring; use the more detailed oneBenno Schulenberg
2008-08-11echo: gettextize the alternative option description tooBenno Schulenberg
2008-08-11dd: clarify meaning of multiplication factors; put xM in orderBenno Schulenberg
2008-08-11doc: remove stray word from date's field width descriptionBenno Schulenberg
2008-08-11date: remove confusing and unneeded sentence from --helpBenno Schulenberg
It makes it unclear what 'sequences' refers to, and the -u option already says enough.
2008-08-11printenv: say what it does when variables are specifiedBenno Schulenberg
2008-08-11doc: put the exitstatus paragraph in a better placeBenno Schulenberg
* doc/coreutils.texi (tsort invocation): move two lines
2008-08-11cp: move a newline to make second message identical to othersBenno Schulenberg
2008-08-11who: Gettextize two forgotten stringsBenno Schulenberg
2008-08-10sort: remove unnecessary declaration of strtodJim Meyering
* src/sort.c (STDC_HEADERS): Remove declaration of strtod.
2008-08-10sort: avoid erroneous castJim Meyering
* src/sort.c (OPEN_MAX): Define if not already defined. (MAX_NMERGE): Remove definition. (specify_nmerge): Don't cast MAX_NMERGE (of type size_t) to unsigned int. Instead, use OPEN_MAX as the fall-back value.
2008-08-10sort: don't print uninitialized in diagnosticJim Meyering
* src/sort.c (specify_nmerge): Do use uinttostr value. Provoke with e.g., sort -m --batch-size=18446744073709551617 Omit quotes around known-numeric value in diagnostic. * tests/misc/sort-merge [nmerge-big]: Tighten ERR_SUBST regexp to require a numeric value in that diagnostic, so this particular failure cannot reappear.
2008-08-09* .gitattributes: Better diff output for texinfo sources.Jim Meyering
2008-08-09dd.c: reduce duplication in new O_FULLBLOCK-defining codeJim Meyering
* src/dd.c (MULTIPLE_BITS_SET): New macro, extracted from... (multiple_bits_set): ...this function. Use a single-line, and far simpler expression (no need to list all O_* symbols again) to validate the derived O_FULLBLOCK value.
2008-08-09* coreutils.texi (factor invocation, expr invocation): Adjust wording.Jim Meyering
2008-08-09expr: avoid compiler warningsJim Meyering
* src/expr.c (die): New "noreturn" function to wrap one-arg use of error (string_too_long): Use die rather than error. (toint): Remove definition of now-unused function. (eval6): Remove a little duplication. Use die rather than error. (dodivide): Remove declaration of now-unused variable.
2008-08-09* tests/misc/expr: Add tests of the new GMP-based code.Jim Meyering
2008-08-06expr: support arbitrary-precision arithmeticJames Youngman
* src/Makefile.am (expr_LDADD): Link expr against GNU MP. * doc/coreutils.texi (expr invocation): Describe --bignum, --no-bignum. Explain the new arbitrary-precision functionality. * NEWS: Indicate that arbitrary-precision arithmetic is now supported in expr. * src/expr.c (enum valtype): Added mp_integer, signifying a GNU MP number. (usage): Document the new options --bignum and --no-bignum which force and prohibit the use of arbitrary-precision arithmetic, respectively. (long_options): data structure for getopt_long, which we need to use to parse the options mentioned above. (main): parse these options with getopt_long instead of parse_long_options. (valinfo): Downgrade the numeric member of the union from intmax_t to signed long, since MP lacks functions for promoting an intmax_t to an arbitrary-precision quantity. (enum arithmetic_mode): Represents the current choice between --bignum, --no-bignum and the default (automatically switch from one to the other if needed). (integer_overflow): issue a more explicit error message indicating that MP is not available. (string_too_long): new function, emits a fatal error message for the case where an argument to the 'index' expression is too long for a string offset to be represented. (int_value): With --bignum, create the value as mp_integer rather than plain integer. (substr_value): factored out of eval6; implements "substr". (freev): also destroy mp_integer values. Check that no mp_integer values exist if --no-bignum was specified. (printv, null, tostring): support mp_integer. (toint): new funtion for converting from string or mp_integer to integer. (getsize): extracts a size_t value from a VALUE object; used to implement substr. (promote): promotes a value from integer to mp_integer. (domult, dodivide): functions for multiplication and division, factored out of eval4. (doadd): addition/subraction function, factpred out of eval3. (eval3): support mp_integer types; call doadd. (eval4): support mp_integer types; call domult, dodivide. (eval6): support mp_integer offsets and lengths for "substr" and "index". * TODO: Mention that expr supports arbitrary-precision arithmetic, and suggest that this might also be a good idea for seq. * AUTHORS (expr): Add James Youngman.
2008-08-06doc: mv,cp: undocument the --reply optionJames Youngman
* doc/coreutils.texi (mv invocation): Remove documentation for mv --reply. (cp invocation): Likewise. * NEWS: mention this.
2008-08-06document the supported baud rates beyond 38400James Youngman
* doc/coreutils.texi (Special): Document the supported baud rates beyond 38400.
2008-08-05ls: ignore spurious getfilecon failure due to lack of SELinux supportJohn David Anglin
* src/ls.c (gobble_file): Upon failed getfilecon, treat an errno value of EOPNOTSUPP just like ENOTSUP. See <http://bugs.debian.org/488549>.
2008-08-05Document uptime.James Youngman
* doc/coreutils.texi (uptime invocation): document uptime. * TODO: uptime is documented now. * src/uptime.c (print_uptime): Use fprintftime to print the time, rather than printf. This should make the situation better for translations.
2008-08-04doc: correct and normalize --help output of several toolsBenno Schulenberg
* src/chroot.c (usage): Add "[ARG]" to synopsis. * src/cut.c (usage): Remove an inconsistent period in an option description. * src/du.c (usage): Remove superfluous argument after short option -X. Also remove inconsistent uppercase and final period. Use a single indent level for prettiness. * src/shred.c (usage): Normalize the synopsis. * src/stty.c (usage): Options -F and --file are alternatives, cannot both be used. * src/sum.c (usage): -r does not overrule -s; the last one counts. * src/uptime.c (usage): Remove inconsistent space from the synopsis. * src/users.c: Likewise.
2008-08-04false: mark "false" description for translationJim Meyering
* src/true.c (usage): Mark both strings with N_, so that the one for "false" is also extracted for translation. For consistency, mark both, although only the latter one needed it. Inspired by a patch from Benno Schulenberg.
2008-08-04factor: credit Torbjörn GranlundJames Youngman
* src/factor.c: Credit Torbjörn Granlund as the author of the arbitrary-precision factorization code.
2008-08-03doc: make it clear we're talking about the Linux kernelJim Meyering
* doc/coreutils.texi (mv invocation): tweak wording
2008-08-02tests: fix build-aux/check.mk for non-GNU makeRalf Wildenhues
* build-aux/check.mk ($(TEST_LOGS)) [!GNU_MAKE]: Check for a $(TESTS) test in the build dir, before one in srcdir. For details, see <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/14198>.
2008-08-02* bootstrap: Fix unportable expr usage.Ralf Wildenhues
2008-08-01ls: --color now highlights files with capabilities, tooKamil Dudka
* src/ls.c: [HAVE_CAP] Include <sys/capability.h>. (has_capability): New function for capability detection. (print_color_indicator): Colorize file with capability. * m4/jm-macro.m4: New configure option: --disable-libcap. Check for libcap usability. * src/Makefile.am (dir_LDADD, ls_LDADD, ...): Append $(LIB_CAP). * src/dircolors.c: Update color lists. * src/dircolors.hin: Mention new CAPABILITY color attribute. * tests/ls/capability: Test for ls - colorize file with capability. * tests/Makefile.am (root_tests): Add ls/capability. * NEWS: Mention the change.
2008-08-01factor arbitrarily large numbersJames Youngman
* m4/gmp.m4: New file; adds cu_GMP, which detects GNU MP. * configure.ac: Use cu_GMP. * src/Makefile.am: Link factor against libgmp if available. * src/factor.c: Use GNU MP if it is available. (emit_factor, emit_ul_factor, factor_using_division, factor_using_pollard_rho, extract_factors_multi, sort_and_print_factors, free_factors): new functions for the arbitrary-precision implementation, taken from an example in GNU MP. (factor_wheel): Renamed; was called factor. (print_factors_single): Renamed; was called print_factors. (print_factors): New function, chooses between the single- and arbitrary-precision algorithms according to availability of GNU MP and the length of the number to be factored. (usage, main): New options --bignum and --no-bignum. * coreutils.texi (factor invocation): Document new command-line options for the MP implementation and update the performance numbers to take into account the asymptotically faster algorithm. * TODO: Remove item about factoring large primes (it's done). * m4/gmp.m4: Add support for --without-gmp. * NEWS: Mention the new feature.
2008-08-01ls -U1 now uses constant memoryKamil Dudka
When printing one name per line and not sorting, ls now uses constant memory per directory, no matter how many files are in the directory. * ls.c (print_dir): Print each file name immediately, when possible. * NEWS: Mention the improvement.
2008-07-30* timeout.c: Fix grammar in a comment. Normalize comment syntax.Jim Meyering
2008-07-28bootstrap: work also when there are no .po files in po/Jim Meyering
* bootstrap (update_po_files): Complete the change that I began in 7ba2dd808232cff3ee76aaceb97f4381c3c9cde4.
2008-07-27* NEWS: Move shuf --zero-terminated item into bug-fixes section.Jim Meyering
2008-07-27shuf: correctly document --head-countMikael Magnusson
* src/shuf.c (usage): Correct --help output. * doc/coreutils.texi: Correct option listing. * NEWS: Mention correction.
2008-07-27shuf: honor --zero-terminated option even with --input-range=LO-HIJim Meyering
* src/shuf.c (write_permuted_output): Add EOLBYTE parameter and use it rather than hard-coding "\n". (main): Adjust sole caller. * tests/misc/shuf: Add a test to exercise this bug fix. * NEWS: Mention it.
2008-07-23dd: minor fullblock changesJim Meyering
* src/dd.c (O_FULLBLOCK): Define using an enum, not #define. Derive the value, rather than hard-coding to one that might conflict. (usage): Mention iflag=fullblock in --help output. (scanargs): Reset the O_FULLBLOCK bit, so that we don't try to set an undefined attribute via fcntl (fd, F_SETFL, ... * tests/dd/misc: Signal framework_failure when necessary. Use "compare actual expected", so any diffs look "right". * NEWS (dd): Alphabetize and reword. * coreutils.texi (dd invocation): Adjust wording.
2008-07-23dd: new option: iflag=fullblock to accumulate full input blocksKamil Dudka
* src/dd.c (iread_fullblock): New function for reading full blocks. (scanargs): Check for new parameter iflag=fullblock. (skip): Use iread_fnc pointer instead of iread function. (dd_copy): Use iread_fnc pointer instead of iread function. * tests/dd/misc: Add test for dd - read full blocks. * doc/coretuils.texi: Mention new parameter iflag=fullblock. * NEWS: Mentioned the change.
2008-07-23dd: adjust --help output so help2man formats the man page properlyJim Meyering
* src/dd.c (usage): Use two spaces (not one) to separate "directory" from its description, so help2man formats the derived man page properly.
2008-07-23doc: add example .bashrc code for a ~/.dircolors fileReuben Thomas
* coreutils.texi: Add tip for .bashrc use from Jim Meyering.
2008-07-22tests: do not run chmod on a prefix of space-embedded tmpdirJim Meyering
* TESTS/test-lib.sh (remove_tmp_): New function. (trap 0): Use it instead of open-coded (and misquoted) version.
2008-07-22tests: ensure "make check" w/tainted build dir no longer impacts $HOMEJim Meyering
* maint.mk (taint-distcheck): New rule. (maintainer-distcheck): Make it.