summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorPaul Eggert <eggert@cs.ucla.edu>2014-02-23 15:34:48 -0800
committerPaul Eggert <eggert@cs.ucla.edu>2014-02-23 15:35:27 -0800
commit9f60f37a28c37acb66aa38003ccaa07f13abbd9d (patch)
treeb7fb5360fe4b32fe3ac4cbb6b6f2ca80543822cd /tests
parent85c925ef54348d795e3549d7b01ceb2d57096a50 (diff)
downloadcoreutils-9f60f37a28c37acb66aa38003ccaa07f13abbd9d.tar.xz
shuf: with -r, don't dump core if the input is empty
Problem reported by valiant xiao in <http://bugs.gnu.org/16855>. * NEWS: Document this. * src/shuf.c (main): With -r, report an error if the input is empty. * tests/misc/shuf.sh: Test for the bug.
Diffstat (limited to 'tests')
-rwxr-xr-xtests/misc/shuf.sh4
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/misc/shuf.sh b/tests/misc/shuf.sh
index d3ea1f2ee..d7251d1d6 100755
--- a/tests/misc/shuf.sh
+++ b/tests/misc/shuf.sh
@@ -43,6 +43,10 @@ compare in out1 || { fail=1; echo "not a permutation" 1>&2; }
t=$(shuf -e a b c d e | sort | fmt)
test "$t" = 'a b c d e' || { fail=1; echo "not a permutation" 1>&2; }
+# coreutils-8.22 dumps core.
+shuf -er
+test $? -eq 1 || fail=1
+
# Before coreutils-6.3, this would infloop.
# "seq 1860" produces 8193 (8K + 1) bytes of output.
seq 1860 | shuf > /dev/null || fail=1