summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorEric Blake <ebb9@byu.net>2009-08-28 10:59:16 -0600
committerEric Blake <ebb9@byu.net>2009-08-28 12:56:51 -0600
commit31fa922e5765a24786061a4dfbd048869457cf84 (patch)
tree906654cadaeaa4fc23dbb0120ab7ffa6558fe4c6 /tests
parent59a6ddfca34bea0d657cf4d9f56aa6d5bab4a7a1 (diff)
downloadcoreutils-31fa922e5765a24786061a4dfbd048869457cf84.tar.xz
dd: detect closed stderr
* src/dd.c (maybe_close_stdout): Always flush stderr; regression introduced in commit 381e69ea. * tests/misc/close-stdout (p): Use consistent style. * tests/dd/stderr: New test, borrowing from misc/close-stdout. * tests/Makefile.am (TESTS): Run it. * NEWS: Mention this.
Diffstat (limited to 'tests')
-rw-r--r--tests/Makefile.am1
-rwxr-xr-xtests/dd/stderr48
-rwxr-xr-xtests/misc/close-stdout2
3 files changed, 50 insertions, 1 deletions
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 6ad61331c..c88dd9c44 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -305,6 +305,7 @@ TESTS = \
dd/skip-seek \
dd/skip-seek2 \
dd/skip-seek-past-file \
+ dd/stderr \
dd/unblock-sync \
df/total-verify \
du/2g \
diff --git a/tests/dd/stderr b/tests/dd/stderr
new file mode 100755
index 000000000..a6c8fba4e
--- /dev/null
+++ b/tests/dd/stderr
@@ -0,0 +1,48 @@
+#!/bin/sh
+# Ensure dd recognizes failure to write to stderr.
+
+# Copyright (C) 2009 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+if test "$VERBOSE" = yes; then
+ set -x
+ dd --version
+fi
+
+. $srcdir/test-lib.sh
+
+p=$abs_top_builddir
+
+fail=0
+
+# Ensure this exits successfully, even though stderr is closed,
+# because it generates no stderr output.
+dd --help >/dev/null 2>&- || fail=1
+
+# If 2>&- works, ensure this fails, because stderr is closed and it
+# *does* generate output. 2>&- apparently does not work in HP-UX 11.23.
+# This test is ineffective unless /dev/stderr also works.
+# This exposes a failure present in 6.11 through 7.5.
+if "$p/src/test" -w /dev/stderr 2>/dev/null &&
+ "$p/src/test" ! -w /dev/stderr 2>&-; then
+ : | dd 2>&- && fail=1
+fi
+
+# Likewise for /dev/full, if /dev/full works.
+if test -w /dev/full && test -c /dev/full; then
+ : | dd 2>/dev/full && fail=1
+fi
+
+Exit $fail
diff --git a/tests/misc/close-stdout b/tests/misc/close-stdout
index d5fdbb9d4..fe911d8a9 100755
--- a/tests/misc/close-stdout
+++ b/tests/misc/close-stdout
@@ -24,7 +24,7 @@ fi
. $srcdir/test-lib.sh
-p="$abs_top_builddir"
+p=$abs_top_builddir
fail=0