summaryrefslogtreecommitdiff
path: root/tests/tail-2
diff options
context:
space:
mode:
authorPádraig Brady <P@draigBrady.com>2010-01-13 12:19:26 +0000
committerJim Meyering <meyering@redhat.com>2010-01-13 13:42:49 +0100
commite55d8828111bf6f9ff0f419fe0045de6ecd1ecaa (patch)
tree0f9cfe946e27e5338cf2a03a3f4ed546165934f5 /tests/tail-2
parentf28c7d959be30be0b216880878e8b0909d810a18 (diff)
downloadcoreutils-e55d8828111bf6f9ff0f419fe0045de6ecd1ecaa.tar.xz
tests: avoid spurious failures on older shells
* tests/tail-2/inotify-hash-abuse: Use kill rather than wait to determine if the tail process is still running. * tests/tail-2/inotify-hash-abuse2: Ditto.
Diffstat (limited to 'tests/tail-2')
-rwxr-xr-xtests/tail-2/inotify-hash-abuse15
-rwxr-xr-xtests/tail-2/inotify-hash-abuse212
2 files changed, 5 insertions, 22 deletions
diff --git a/tests/tail-2/inotify-hash-abuse b/tests/tail-2/inotify-hash-abuse
index ab5a69ecd..65a341211 100755
--- a/tests/tail-2/inotify-hash-abuse
+++ b/tests/tail-2/inotify-hash-abuse
@@ -46,23 +46,14 @@ echo a > 1 || fail=1
# Wait up to 2s for the buggy tail to die,
# or for the "tail: `1' has appeared; following end of new file" output
-dead=0
for i in $(seq 10); do
- kill -0 $pid || { dead=1; break; }
+ kill -0 $pid || break
grep 'has appeared;' out > /dev/null && break
sleep .2
done
-# Fixed tail will not have aborted. Kill it.
-test $dead = 0 && kill -HUP $pid
-
-wait $pid
-st=$?
-
-case $st in
- 129) ;;
- *) echo tail died via unexpected signal: $st; fail=1;;
-esac
+# Kill the working tail, or fail if it has already aborted
+kill $pid || fail=1
cat out
diff --git a/tests/tail-2/inotify-hash-abuse2 b/tests/tail-2/inotify-hash-abuse2
index 4fe080bd2..2e567c799 100755
--- a/tests/tail-2/inotify-hash-abuse2
+++ b/tests/tail-2/inotify-hash-abuse2
@@ -36,15 +36,7 @@ for i in $(seq 200); do
touch f
done
-# Fixed tail will not have aborted. Kill it.
-kill -HUP $pid
-
-wait $pid
-st=$?
-
-case $st in
- 129) ;;
- *) echo tail died via unexpected signal: $st; fail=1;;
-esac
+# Kill the working tail, or fail if it has already aborted
+kill $pid || fail=1
Exit $fail