summaryrefslogtreecommitdiff
path: root/tests/misc
diff options
context:
space:
mode:
authorPádraig Brady <P@draigBrady.com>2009-12-22 07:36:12 +0000
committerPádraig Brady <P@draigBrady.com>2009-12-23 13:45:34 +0000
commit11dc0016bb72372bbd46b964fb57f4d10448225a (patch)
treeeef2f1ed04939d441e60c26e6751564d3a84311a /tests/misc
parent53db8d6479019474a14b8b858e83ace450195034 (diff)
downloadcoreutils-11dc0016bb72372bbd46b964fb57f4d10448225a.tar.xz
wc: line-buffer the printed counts
* src/wc.c (main): Set stdout to line buffered mode to ensure parallel running instances don't intersperse their output. This adds 6.5% to the run time in the worst case of many zero length files, but has neglible impact for standard sized files. * tests/misc/wc-parallel: New test for atomic output. * tests/Makefile.am: Reference it. * NEWS: Mention the fix This is similar to commit 710fe413, 20-10-2009, "md5sum, sha*sum, sum: line-buffer the printed checksums"
Diffstat (limited to 'tests/misc')
-rwxr-xr-xtests/misc/wc-parallel37
1 files changed, 37 insertions, 0 deletions
diff --git a/tests/misc/wc-parallel b/tests/misc/wc-parallel
new file mode 100755
index 000000000..7c74c5518
--- /dev/null
+++ b/tests/misc/wc-parallel
@@ -0,0 +1,37 @@
+#!/bin/sh
+# Ensure that wc prints counts atomically
+# so that concurrent processes don't intersperse their output
+
+# Copyright (C) 2009 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+. $srcdir/test-lib.sh
+
+if test "$VERBOSE" = yes; then
+ set -x
+ md5sum --version
+fi
+
+
+(mkdir tmp && cd tmp && seq 2000 | xargs touch)
+
+# This will output at least 16KiB per process
+# and start 3 processes, with 2 running concurrently,
+# which triggers often on Fedora 11 at least.
+(find tmp tmp tmp -type f | xargs -n2000 -P2 wc) |
+sed -n '/0 0 0 /!p' |
+grep . > /dev/null && fail=1
+
+Exit $fail