diff options
| author | Pádraig Brady <P@draigBrady.com> | 2014-03-05 18:41:16 +0000 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2014-03-05 19:02:20 +0000 |
| commit | 056d6de78fcf11a0f404f25faf8cecc9f9ee9c1c (patch) | |
| tree | cd5235d3fd1e8b0142c543541675dd66f26c3d91 /tests/install | |
| parent | 5dce6bdfafc930dfd17d5d16aea7d1add3472066 (diff) | |
| download | coreutils-056d6de78fcf11a0f404f25faf8cecc9f9ee9c1c.tar.xz | |
tests: avoid the :> construct which can hide errors
On most shells `:>file || framework_failure_` will not evaluate
the framework_failure_ even if there was an error writing the file.
shells which do evaluate the failure are ksh 93u+ and bash 4.2,
while shells wich don't include bash 4.3, solaris, freebsd, dash.
Furthermore this construct is problematic on Solaris 10 sh,
which will try to optimize away a `:' command in a loop
after the first iteration, even if it is redirected.
* tests/cp/link-deref.sh: Remove the leading colon on redirections.
* tests/cp/reflink-perm.sh: Likewise.
* tests/id/zero.sh: Likewise.
* tests/install/install-C.sh: Likewise.
* tests/misc/env.sh: Likewise.
* tests/misc/md5sum-bsd.sh: Likewise.
* tests/misc/runcon-no-reorder.sh: Likewise.
* tests/mv/partition-perm.sh: Likewise.
* tests/rm/r-root.sh: Likewise.
* tests/split/l-chunk.sh: Likewise.
* tests/split/line-bytes.sh: Likewise.
* tests/tail-2/inotify-rotate.sh: Likewise.
* tests/tail-2/retry.sh: Likewise.
* tests/tail-2/symlink.sh: Likewise.
* tests/tail-2/wait.sh: Likewise.
* tests/touch/read-only.sh: Likewise.
+ cfg.mk (sc_prohibit_colon_redirection): A new syntax check
to avoid further instances of this creeping in.
Diffstat (limited to 'tests/install')
| -rwxr-xr-x | tests/install/install-C.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/install/install-C.sh b/tests/install/install-C.sh index 6ce4977a9..9ee1685a8 100755 --- a/tests/install/install-C.sh +++ b/tests/install/install-C.sh @@ -54,7 +54,7 @@ echo test > a || framework_failure_ echo "'a' -> 'b'" > out_installed_first || framework_failure_ echo "removed 'b' 'a' -> 'b'" > out_installed_second || framework_failure_ -: > out_empty || framework_failure_ +> out_empty || framework_failure_ # destination file does not exist ginstall -Cv -m$mode1 a b > out || fail=1 |