diff options
author | Pádraig Brady <P@draigBrady.com> | 2010-02-26 15:33:16 +0000 |
---|---|---|
committer | Pádraig Brady <P@draigBrady.com> | 2010-03-01 10:58:02 +0000 |
commit | 59e2e55d0f154a388adc9bac37d2b45f2ba971f8 (patch) | |
tree | 28b45daf114e30b79db3f9110683ef6d6b48c5aa /src | |
parent | 2590389aabc3ac2e88c56a13d28fa3caa22a5b46 (diff) | |
download | coreutils-59e2e55d0f154a388adc9bac37d2b45f2ba971f8.tar.xz |
sort: fix issues with month sorting in some locales
* src/sort.c (char fold_toupper[]): Change to unsigned
so as the correct comparisons are made in getmonth().
This fixes unibyte locales where abbreviated months
have characters that are > 0x7F, but it also works for
multibyte locales with the caveat that multibyte characters
are matched case sensitively.
With this change, the following example sorts correctly:
$ echo -e "1 márta\n2 Feabhra" | LANG=ga_IE.utf8 sort -k2,2M
2 Feabhra
1 márta
* src/sort.c (inittables): Since we ignore blanks around months
in the input, don't include them when they're present in the locale.
With this change, the following example sorts correctly:
$ echo -e "1 2月\n2 1月" | LANG=ja_JP.utf8 sort -k2,2M
2 1月
1 2月
* tests/misc/sort-month: A new test to exercise the above cases.
* tests/Makefile.am: Reference the new test.
* NEWS: Mention the fix.
Diffstat (limited to 'src')
-rw-r--r-- | src/sort.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/sort.c b/src/sort.c index 481fdb8bb..39cb6d6f2 100644 --- a/src/sort.c +++ b/src/sort.c @@ -209,7 +209,7 @@ static bool nonprinting[UCHAR_LIM]; static bool nondictionary[UCHAR_LIM]; /* Translation table folding lower case to upper. */ -static char fold_toupper[UCHAR_LIM]; +static unsigned char fold_toupper[UCHAR_LIM]; #define MONTHS_PER_YEAR 12 @@ -1129,7 +1129,7 @@ inittables (void) { char const *s; size_t s_len; - size_t j; + size_t j, k; char *name; s = (char *) nl_langinfo (ABMON_1 + i); @@ -1137,9 +1137,10 @@ inittables (void) monthtab[i].name = name = xmalloc (s_len + 1); monthtab[i].val = i + 1; - for (j = 0; j < s_len; j++) - name[j] = fold_toupper[to_uchar (s[j])]; - name[j] = '\0'; + for (j = k = 0; j < s_len; j++) + if (! isblank (to_uchar (s[j]))) + name[k++] = fold_toupper[to_uchar (s[j])]; + name[k] = '\0'; } qsort ((void *) monthtab, MONTHS_PER_YEAR, sizeof *monthtab, struct_month_cmp); |