summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorOndrej Oprala <ooprala@redhat.com>2013-02-22 13:48:57 +0100
committerBernhard Voelker <mail@bernhard-voelker.de>2013-02-22 21:31:32 +0100
commit3a20f6888575be7059e9acac07d397009e98c213 (patch)
treef550329b8763bd36cf2b4c7c4775873169795e28 /src
parent6229654741554561952c6106f75681e4382cc890 (diff)
downloadcoreutils-3a20f6888575be7059e9acac07d397009e98c213.tar.xz
install: cleanup properly if the strip program failed for any reason
* src/install.c (strip): Indicate failure with a return code instead of terminating the program. (install_file_in_file): Handle strip's return code and unlink the created file if necessary. * tests/install/strip-program.sh: Add a test to cover the changes. * NEWS (Bug fixes): Mention the fix. Reported by John Reiser in http://bugzilla.redhat.com/632444.
Diffstat (limited to 'src')
-rw-r--r--src/install.c19
1 files changed, 14 insertions, 5 deletions
diff --git a/src/install.c b/src/install.c
index 94374df3e..a5ed7a821 100644
--- a/src/install.c
+++ b/src/install.c
@@ -515,16 +515,17 @@ change_timestamps (struct stat const *src_sb, char const *dest)
magic numbers vary so much from system to system that making
it portable would be very difficult. Not worth the effort. */
-static void
+static bool
strip (char const *name)
{
int status;
+ bool ok = false;
pid_t pid = fork ();
switch (pid)
{
case -1:
- error (EXIT_FAILURE, errno, _("fork system call failed"));
+ error (0, errno, _("fork system call failed"));
break;
case 0: /* Child. */
execlp (strip_program, strip_program, name, NULL);
@@ -532,11 +533,14 @@ strip (char const *name)
break;
default: /* Parent. */
if (waitpid (pid, &status, 0) < 0)
- error (EXIT_FAILURE, errno, _("waiting for strip"));
+ error (0, errno, _("waiting for strip"));
else if (! WIFEXITED (status) || WEXITSTATUS (status))
- error (EXIT_FAILURE, 0, _("strip process terminated abnormally"));
+ error (0, 0, _("strip process terminated abnormally"));
+ else
+ ok = true; /* strip succeeded */
break;
}
+ return ok;
}
/* Initialize the user and group ownership of the files to install. */
@@ -681,7 +685,12 @@ install_file_in_file (const char *from, const char *to,
if (! copy_file (from, to, x))
return false;
if (strip_files)
- strip (to);
+ if (! strip (to))
+ {
+ if (unlink (to) != 0) /* Cleanup. */
+ error (EXIT_FAILURE, errno, _("cannot unlink %s"), to);
+ return false;
+ }
if (x->preserve_timestamps && (strip_files || ! S_ISREG (from_sb.st_mode))
&& ! change_timestamps (&from_sb, to))
return false;