all: use die() rather than error(EXIT_FAILURE)

die() has the advantage of being apparent to the compiler
that it doesn't return, which will avoid warnings in some cases,
and possibly generate better code.
* cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to
catch any new uses of error (CONSTANT, ...);

1 files changed, 2 insertions, 1 deletions

diff --git a/src/who.c b/src/who.c
index d5f573255..55733b43b 100644
--- a/src/who.c
+++ b/src/who.c
@@ -34,6 +34,7 @@
 #include "c-ctype.h"
 #include "canon-host.h"
 #include "readutmp.h"
+#include "die.h"
 #include "error.h"
 #include "hard-locale.h"
 #include "quote.h"
@@ -622,7 +623,7 @@ who (const char *filename, int options)
   STRUCT_UTMP *utmp_buf;
 
   if (read_utmp (filename, &n_users, &utmp_buf, options) != 0)
-    error (EXIT_FAILURE, errno, "%s", quotef (filename));
+    die (EXIT_FAILURE, errno, "%s", quotef (filename));
 
   if (short_list)
     list_entries_who (n_users, utmp_buf);