diff options
| author | Paul Eggert <eggert@CS.UCLA.EDU> | 2008-10-24 22:52:22 -0700 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2008-10-25 10:59:07 +0200 |
| commit | 461231f022bdb3ee392622d31dc475034adceeb2 (patch) | |
| tree | f0709db8cd6e0177801ea7d32eaa9ae30ca9faf3 /src/seq.c | |
| parent | b705e9a9e71546f3da2d3f5f966363e62b74d057 (diff) | |
| download | coreutils-461231f022bdb3ee392622d31dc475034adceeb2.tar.xz | |
seq: revert Solaris 8 work-around that caused x86 regression
* src/seq.c: Don't include <math.h>, <float.h>.
(abs_rel_diff): Remove.
(print_numbers): Test for equality, not for an epsilonish value.
This reverts 4827dd27b0c655a685947aaa01426a5ecba179f3, aka
v6.10-185-g4827dd2, which broke 'seq' on the x86; for example, it
causes "seq 9223372036854775807 9223372036854775808" to incorrectly
output 3 numbers instead of 2. It's better to punish obsolescent
hosts that have incorrectly-working floating-point than to punish
correctly-working hosts.
* tests/misc/seq: Use 0.9000000000000, rather than
0.90000000000000000000, to avoid tickling a bug in Solaris 8 strtold,
which converts "0.9" and "0.9000000000000" correctly, but incorrectly
converts "0.90000000000000000000" to a smaller value.
Diffstat (limited to 'src/seq.c')
| -rw-r--r-- | src/seq.c | 12 |
1 files changed, 1 insertions, 11 deletions
@@ -20,8 +20,6 @@ #include <getopt.h> #include <stdio.h> #include <sys/types.h> -#include <math.h> -#include <float.h> #include "system.h" #include "c-strtod.h" @@ -258,14 +256,6 @@ long_double_format (char const *fmt, struct layout *layout) return NULL; } -/* Return the absolute relative difference from x to y. */ -static double -abs_rel_diff (double x, double y) -{ - double s = (y == 0.0 ? 1 : y); - return fabs ((y - x) / s); -} - /* Actually print the sequence of numbers in the specified range, with the given or default stepping and format. */ @@ -310,7 +300,7 @@ print_numbers (char const *fmt, struct layout layout, x_str[x_strlen - layout.suffix_len] = '\0'; if (xstrtold (x_str + layout.prefix_len, NULL, &x_val, c_strtold) - && abs_rel_diff (x_val, last) < DBL_EPSILON) + && x_val == last) { char *x0_str = NULL; if (asprintf (&x0_str, fmt, x0) < 0) |