summaryrefslogtreecommitdiff
path: root/src/nl.c
diff options
context:
space:
mode:
authorPádraig Brady <P@draigBrady.com>2016-10-15 23:10:35 +0100
committerPádraig Brady <P@draigBrady.com>2016-10-16 12:23:55 +0100
commit492dcb2eb191b844a2fd5e51db3eed85289bea1f (patch)
tree910f93d88891b573520ebd5c812d61ddc7fbeed8 /src/nl.c
parentd035eacfdeba2da0134e606c8a63b2f3c0bd05bb (diff)
downloadcoreutils-492dcb2eb191b844a2fd5e51db3eed85289bea1f.tar.xz
all: use die() rather than error(EXIT_FAILURE)
die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...);
Diffstat (limited to 'src/nl.c')
-rw-r--r--src/nl.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/nl.c b/src/nl.c
index 9696526a2..623b95c26 100644
--- a/src/nl.c
+++ b/src/nl.c
@@ -256,7 +256,7 @@ build_type_arg (char const **typep,
RE_SYNTAX_POSIX_BASIC & ~RE_CONTEXT_INVALID_DUP & ~RE_NO_EMPTY_RANGES;
errmsg = re_compile_pattern (optarg, strlen (optarg), regexp);
if (errmsg)
- error (EXIT_FAILURE, 0, "%s", (errmsg));
+ die (EXIT_FAILURE, 0, "%s", (errmsg));
break;
default:
rval = false;
@@ -276,7 +276,7 @@ print_lineno (void)
next_line_no = line_no + page_incr;
if (next_line_no < line_no)
- error (EXIT_FAILURE, 0, _("line number overflow"));
+ die (EXIT_FAILURE, 0, _("line number overflow"));
line_no = next_line_no;
}
@@ -589,7 +589,7 @@ main (int argc, char **argv)
ok &= nl_file (argv[optind]);
if (have_read_stdin && fclose (stdin) == EOF)
- error (EXIT_FAILURE, errno, "-");
+ die (EXIT_FAILURE, errno, "-");
return ok ? EXIT_SUCCESS : EXIT_FAILURE;
}