* src/ls.c (gobble_file): Make it so failure to stat a

non-command-line file provokes an exit status of 1, not 0.
Say "cannot access" rather than "cannot stat".
* tests/ls/stat-failed: New file/test, for the above.
* tests/ls/Makefile.am (TESTS): Add stat-failed.

1 files changed, 6 insertions, 7 deletions

diff --git a/src/ls.c b/src/ls.c
index 457256d5b..64411d19e 100644
--- a/src/ls.c
+++ b/src/ls.c
@@ -2611,14 +2611,13 @@ gobble_file (char const *name, enum filetype type, ino_t inode,
       f->stat_failed = (err < 0);
       if (f->stat_failed)
 	{
-	  /* We treat stat failures for files the user named special.
-	     There is no guarantee that these files really exist so
-	     we do not print any information.  */
+	  /* Failure to stat a command line argument leads to
+	     an exit status of 2.  For other files, stat failure
+	     provokes an exit status of 1.  */
+	  file_failure (command_line_arg,
+			_("cannot access %s"), absolute_name);
 	  if (command_line_arg)
-	    {
-	      file_failure (1, "%s", absolute_name);
-	      return 0;
-	    }
+	    return 0;
 
 	  f->filetype = type;
 	  memset (&f->stat, '\0', sizeof (f->stat));