diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2007-12-01 10:09:57 +0100 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2007-12-01 10:09:57 +0100 |
| commit | b64119bc54791809b9fc3a225761b1c913fe66bc (patch) | |
| tree | 15566919c6c92780e8677a300cef940668fe2bad /src/install.c | |
| parent | 317413874c935c8605ae3549e7575e03427b953e (diff) | |
| download | coreutils-b64119bc54791809b9fc3a225761b1c913fe66bc.tar.xz | |
Fix a security race with "cp -p A B" when B already exists.
* src/copy.h (struct cp_options): New member owner_privileges.
* src/copy.c (USE_ACL): Define to 0 if not defined, for convenience.
(owner_failure_ok): New function.
(set_owner): Avoid a security-related race by doing an extra chmod
first if it looks like there might be trouble right after a chown.
Accept a source struct stat rather than a uid and gid, and
accept a boolean NEW_DST and destination struct stat.
All callers changed.
* src/copy.h (cp_options_default): New function, replacing the
old chown_privileges.
* src/copy.c (cp_options_default): Likewise.
* src/cp.c (cp_option_init): Use it.
* src/install.c (cp_option_init): Likewise.
* src/mv.c (cp_option_init): Likewise.
Diffstat (limited to 'src/install.c')
| -rw-r--r-- | src/install.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/install.c b/src/install.c index 802dfcf77..db08751e4 100644 --- a/src/install.c +++ b/src/install.c @@ -163,6 +163,7 @@ static struct option const long_options[] = static void cp_option_init (struct cp_options *x) { + cp_options_default (x); x->copy_as_regular = true; x->dereference = DEREF_ALWAYS; x->unlink_dest_before_opening = true; @@ -170,7 +171,6 @@ cp_option_init (struct cp_options *x) x->hard_link = false; x->interactive = I_UNSPECIFIED; x->move_mode = false; - x->chown_privileges = chown_privileges (); x->one_file_system = false; x->preserve_ownership = false; x->preserve_links = false; |