all: use die() rather than error(EXIT_FAILURE)

die() has the advantage of being apparent to the compiler
that it doesn't return, which will avoid warnings in some cases,
and possibly generate better code.
* cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to
catch any new uses of error (CONSTANT, ...);

1 files changed, 6 insertions, 5 deletions

diff --git a/src/hostname.c b/src/hostname.c
index 11f30326a..cc29750f5 100644
--- a/src/hostname.c
+++ b/src/hostname.c
@@ -23,6 +23,7 @@
 
 #include "system.h"
 #include "long-options.h"
+#include "die.h"
 #include "error.h"
 #include "quote.h"
 #include "xgethostname.h"
@@ -91,11 +92,11 @@ main (int argc, char **argv)
       /* Set hostname to operand.  */
       char const *name = argv[optind];
       if (sethostname (name, strlen (name)) != 0)
-        error (EXIT_FAILURE, errno, _("cannot set name to %s"),
-               quote (name));
+        die (EXIT_FAILURE, errno, _("cannot set name to %s"),
+             quote (name));
 #else
-      error (EXIT_FAILURE, 0,
-             _("cannot set hostname; this system lacks the functionality"));
+      die (EXIT_FAILURE, 0,
+           _("cannot set hostname; this system lacks the functionality"));
 #endif
     }
 
@@ -103,7 +104,7 @@ main (int argc, char **argv)
     {
       hostname = xgethostname ();
       if (hostname == NULL)
-        error (EXIT_FAILURE, errno, _("cannot determine hostname"));
+        die (EXIT_FAILURE, errno, _("cannot determine hostname"));
       printf ("%s\n", hostname);
     }