all: quote string arguments in error messages

These strings are often file names or other user specified
parameters, which can give confusing errors in
the presence of unexpected characters for example.

* cfg.mk (sc_error_quotes): A new syntax check rule.
* src/*.c: Wrap error() string arguments with quote().
* tests/: Adjust accordingly.
* NEWS: Mention the improvement.

1 files changed, 4 insertions, 3 deletions

diff --git a/src/cut.c b/src/cut.c
index aac91ef5e..b2087695d 100644
--- a/src/cut.c
+++ b/src/cut.c
@@ -34,6 +34,7 @@
 #include "fadvise.h"
 #include "getndelim2.h"
 #include "hash.h"
+#include "quote.h"
 #include "xstrndup.h"
 
 #include "set-fields.h"
@@ -444,7 +445,7 @@ cut_file (char const *file)
       stream = fopen (file, "r");
       if (stream == NULL)
         {
-          error (0, errno, "%s", file);
+          error (0, errno, "%s", quote (file));
           return false;
         }
     }
@@ -455,14 +456,14 @@ cut_file (char const *file)
 
   if (ferror (stream))
     {
-      error (0, errno, "%s", file);
+      error (0, errno, "%s", quote (file));
       return false;
     }
   if (STREQ (file, "-"))
     clearerr (stream);		/* Also clear EOF. */
   else if (fclose (stream) == EOF)
     {
-      error (0, errno, "%s", file);
+      error (0, errno, "%s", quote (file));
       return false;
     }
   return true;