diff options
| author | Pádraig Brady <P@draigBrady.com> | 2009-09-23 10:10:51 +0100 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2009-09-23 14:33:40 +0100 |
| commit | a037e838e15c9a698f1634398e0fe2726398d575 (patch) | |
| tree | 7361ac5f2c3dbd8fc4763e6fa960e6646670dc79 /src/chown-core.c | |
| parent | ade8dd2096e1898edefadf2314d4e1ec654adda5 (diff) | |
| download | coreutils-a037e838e15c9a698f1634398e0fe2726398d575.tar.xz | |
maint: Use logical rather than bitwise operators on bools
This is because bitwise operators are:
- confusing and inconsistent in a boolean context
- non short circuiting
- brittle in C89 where bool can be an int (so > 1)
Diffstat (limited to 'src/chown-core.c')
| -rw-r--r-- | src/chown-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/chown-core.c b/src/chown-core.c index 705a29bd3..e7dacf68c 100644 --- a/src/chown-core.c +++ b/src/chown-core.c @@ -440,7 +440,7 @@ change_file_owner (FTS *fts, FTSENT *ent, if (chopt->verbosity != V_off) { bool changed = - ((do_chown & ok & symlink_changed) + ((do_chown && ok && symlink_changed) && ! ((uid == (uid_t) -1 || uid == file_stats->st_uid) && (gid == (gid_t) -1 || gid == file_stats->st_gid))); |