diff options
| author | Pádraig Brady <P@draigBrady.com> | 2016-11-22 01:23:22 +0000 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2016-11-22 20:04:25 +0000 |
| commit | 055b08ff7853c7c9ab791643047b1b163a227013 (patch) | |
| tree | 15d7a014a486c9c0189cef9511c7e7c7b0470620 /cfg.mk | |
| parent | b572a286d5d24cdb1669baa3f867317bdb534b1a (diff) | |
| download | coreutils-055b08ff7853c7c9ab791643047b1b163a227013.tar.xz | |
tests: fix false fails due to passing env vars to returns_
On BSD /bin/sh it was seen that unexported env vars passed to
returns_() would not be propagated to the wrapped command.
* cfg.mk (sc_prohibit_env_returns): Add a syntax check to disallow.
* tests/misc/csplit-io-err.sh: Rearrange to export vars in a subshell.
* tests/rm/rm-readdir-fail.sh: Likewise.
* tests/misc/nohup.sh: Export and unset vars around returns_.
* tests/misc/printenv.sh: Likewise.
Reported by Assaf Gordon
Diffstat (limited to 'cfg.mk')
| -rw-r--r-- | cfg.mk | 8 |
1 files changed, 8 insertions, 0 deletions
@@ -510,6 +510,14 @@ sc_prohibit_and_fail_1: in_vc_files='^tests/' \ $(_sc_search_regexp) +# Ensure that env vars are not passed through returns_ as +# that was seen to fail on FreeBSD /bin/sh at least +sc_prohibit_env_returns: + @prohibit='=[^ ]* returns_ ' \ + halt='Passing env vars to returns_ is non portable' \ + in_vc_files='^tests/' \ + $(_sc_search_regexp) + # The mode part of a setfacl -m option argument must be three bytes long. # I.e., an argument of user:bin:rw or user:bin:r will make Solaris 10's # setfacl reject it with: "Unrecognized character found in mode field". |